Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 #30

Closed
wants to merge 2 commits into from
Closed

Python3 #30

wants to merge 2 commits into from

Conversation

julienaubert
Copy link

I started from dominicrodger's PR, and did:

  • rebase against master
  • added additional required fixes for python3
  • updated tox. added .travis.yml, and coveralls

Note: I was not able to use runtests.py (it is not used by tox/.travis.yml) - perhaps that one should be removed? (in favour of the setup.py test).

Note: seems some tests are missing, in particular, these methods are not covered at all:

  • value_to_string
  • formfield

and a test using uuid version1 should probably exist as well.

@julienaubert julienaubert mentioned this pull request Mar 4, 2014
@julienaubert
Copy link
Author

Updated: added tests so that value_to_string, formfield and uuid-version1 is covered.

@dcramer, thankful if could be merged in and released - let me know if you have any concerns.

@julienaubert
Copy link
Author

@dcramer - also, would recommend you login to http://travis-ci.org/ and https://coveralls.io/ to enable this repo. (benefits: you get badges showing up-to-date build/coverage in the README: https://github.com/julienaubert/django-uuidfield/tree/python3, and in PR:s you see if the PR passes on travis and can be merged in).

@julienaubert
Copy link
Author

Can this PR go in?

@dcramer
Copy link
Owner

dcramer commented Mar 26, 2014

I haven't really had time to review this and it's a fairly significant change. I'll try to take a look soon, but for now i've enabled Travis

@julienaubert
Copy link
Author

OK, thanks!

@jleclanche
Copy link

@dcramer @julienaubert Any news?

@luto
Copy link
Collaborator

luto commented Nov 5, 2014

#34 got merged and this PR has conflicts.

I am closing this for now, feel free to re-submit what you think is missing. Thank you!

@luto luto closed this Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants