Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Support (#33) #34

Merged
merged 1 commit into from
Nov 4, 2014
Merged

Python 3 Support (#33) #34

merged 1 commit into from
Nov 4, 2014

Conversation

luto
Copy link
Collaborator

@luto luto commented Jul 5, 2014

#33

@chescales
Copy link

+1

2 similar comments
@micahhausler
Copy link

+1

@joshchandler
Copy link

+1

@joshchandler
Copy link

Here's a workaround for this using a SerializerMethod:

class TheModelSerializer(serializers.ModelSerializer):
    uuid = serializers.SerializerMethodField('get_uuid')

    class Meta:
        model = TheModel
        fields = ('...', 'uuid', '...')

    def get_uuid(self, obj):
        return obj.uuid

@jleclanche
Copy link

@dcramer this looks good, can you merge?

dcramer added a commit that referenced this pull request Nov 4, 2014
@dcramer dcramer merged commit ec4f97f into dcramer:master Nov 4, 2014
@luto
Copy link
Collaborator Author

luto commented Nov 4, 2014

Finally, lol. Thanks @dcramer!

Can you also tag, release and publish this, please?

@luto luto deleted the python3 branch November 4, 2014 20:25
@jleclanche
Copy link

@dcramer Hurray!

A release would be welcome, yes. Then I can bump the requirements on django-push-notifications :)

@luto luto mentioned this pull request Nov 5, 2014
@luto luto restored the python3 branch November 8, 2014 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants