Skip to content

Commit

Permalink
Use string.IsNullOrEmpty() rather than null/"" checks.
Browse files Browse the repository at this point in the history
  • Loading branch information
dcramer committed Apr 6, 2010
1 parent eca26d6 commit b93174f
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions MapLoader/PathFinder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,26 +60,26 @@ public void GatherPathes()
pathToStarcraft2Folder = mysc2Registry.Read("InstallPath");

// 1b. Try Registry CurrentUser
if (pathToStarcraft2Folder == null)
if (string.IsNullOrEmpty(pathToStarcraft2Folder))
{
mysc2Registry.BaseRegistryKey = Registry.CurrentUser;
pathToStarcraft2Folder = mysc2Registry.Read("InstallPath");
}

if (pathToStarcraft2Folder == null)
if (string.IsNullOrEmpty(pathToStarcraft2Folder))
{
pathToStarcraft2Folder = "";
}

// 2. Try Default Path
if (pathToStarcraft2Folder == "")
if (string.IsNullOrEmpty(pathToStarcraft2Folder))
{
string sc2_defaultPath = pathToProgramFiles + "/" + "StarCraft II/";
if (File.Exists(pathToProgramFiles + "StarCraft II.exe")) pathToStarcraft2Folder = sc2_defaultPath;
}

// 3. Try Default Path (Beta)
if (pathToStarcraft2Folder == "")
if (string.IsNullOrEmpty(pathToStarcraft2Folder))
{
string defaultPath = pathToProgramFiles + "/" + "StarCraft II Beta/";
if (File.Exists(pathToProgramFiles + "StarCraft II.exe")) pathToStarcraft2Folder = defaultPath;
Expand All @@ -103,19 +103,19 @@ public void GatherPathes()
pathToStarcraft1Folder = mysc1Registry.Read("InstallPath");

// 1b. Try Registry CurrentUser
if (pathToStarcraft1Folder == null)
if (string.IsNullOrEmpty(pathToStarcraft1Folder))
{
mysc1Registry.BaseRegistryKey = Registry.CurrentUser;
pathToStarcraft1Folder = mysc1Registry.Read("InstallPath");
}

if (pathToStarcraft1Folder == null)
if (string.IsNullOrEmpty(pathToStarcraft1Folder))
{
pathToStarcraft1Folder = "";
}

// 2. Try Default Path
if (pathToStarcraft1Folder == "")
if (string.IsNullOrEmpty(pathToStarcraft1Folder))
{
string sc1_defaultPath = pathToProgramFiles + "/" + "StarCraft/";

Expand All @@ -139,13 +139,13 @@ public void GatherPathes()
pathToWarcraft3Folder = mywc3Registry.Read("InstallPath");

// 1b. Try Registry CurrentUser
if (pathToWarcraft3Folder == null)
if (string.IsNullOrEmpty(pathToWarcraft3Folder))
{
mywc3Registry.BaseRegistryKey = Registry.CurrentUser;
pathToWarcraft3Folder = mywc3Registry.Read("InstallPath");
}

if (pathToWarcraft3Folder == null)
if (string.IsNullOrEmpty(pathToWarcraft3Folder))
{
pathToWarcraft3Folder = "";
}
Expand Down

0 comments on commit b93174f

Please sign in to comment.