-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FA18EFG mod support #3338
FA18EFG mod support #3338
Conversation
Changes made to checkbox, icon and banner added for Growler. correct yaml files coming soon
yaml files for F/A-18E and F/A-18F corrected. yaml file for EA-18G added.
yaml files of he F/A-18E and F/A-18F were completely empty for some reason. Correct files re-added
I'm confused. Is this distinct from the super hornet mod you added here? #3331 (which isn't included in the base of this PR, which is why there's a conflict) |
oh yeah that's my bad. The mod was updated wednesday so I'll update the pydcs file and file the PR correctly |
Support updated to CJS F/A18EFG version 2.2.5. Adding: AIM-120D *fix push*
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3338 +/- ##
===========================================
+ Coverage 46.18% 47.82% +1.64%
===========================================
Files 474 476 +2
Lines 26122 26947 +825
Branches 4557 4560 +3
===========================================
+ Hits 12064 12887 +823
- Misses 14035 14037 +2
Partials 23 23 ☔ View full report in Codecov by Sentry. |
@@ -8,6 +7,9 @@ locales: | |||
aircrafts: | |||
- F-14B Tomcat | |||
- F/A-18C Hornet (Lot 20) | |||
- F/A-18E Super Hornet | |||
- F/A-18F Super Hornet | |||
- EA-18G Growler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First flight was 2006 and it wasn't in use until 2009.
aircrafts: | ||
- AH-1W SuperCobra | ||
- C-130J-30 Super Hercules | ||
- F/A-18C Hornet (Lot 20) | ||
- F/A-18E Super Hornet | ||
- F/A-18F Super Hornet | ||
- EA-18G Growler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in 2005 (see other comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The banners won't actually work, afaict. The code only seems to load .jpg
Also, delete the old assets if you're adding new ones?
Closing this PR as it has been replaced with #3340 . |
Support for the F/A-18E, F/A-18F and EA-18G.
Tested and checked by the lovely retribution devs.