-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing tests for accessing data from xcube server via python api #592
Fixing tests for accessing data from xcube server via python api #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to review by following the steps to reproduce in the original issue. I could not reproduce it. The tests work your changes, too, though.
If you delete your .aws (or give it a different name) then you will see the error with the old code :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I could test it now. Works fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tiny minor formatting issue :)
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
…s_xcube_python_api' into alicja-574-fix_server_data_access_xcube_python_api
This PR only fixes the tests for test_s3buckethandlers.py when serving data the classical way: one dataset per identifyer, as in
examples/serve/demo/config.yml
. The data access does not work yet for cubes served via DataStores like in the configexamples/serve/demo/config-with-stores.yml
Checklist:
Add unit tests and/or doctests in docstringsAdd docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*
Changes documented inCHANGES.md
Remember to close associated issues after merge!