-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse @mention thanks as well as thanks @mention #28
Comments
dupe of #35 |
write a |
ok bit more thoughts on how to do this. the scanInput method gets called on every message currently: however, the "thanks" response is not just static text - its a function.
to also return functions, as well as just static text. its a bit meta but i think this would be a really versatile way to implement this and allow us to have keywords trigger functions. |
@irinatag the code for roomMessages is now using regex pls check it out! |
@dcsan sure! |
so this works now with for example the 'txtx' and a @username but can you add a better regex to find the format above on i had to merge in master which included some other changes. this area needs refactoring i think. |
oops, this commit 0ec2592 quite a gnarly merge |
@dcsan ok, thanks for doing that! I'll work on it. |
@dcsan pushed my regex. one issue that's now popping up: the warning that I already gave you points gets logged, but doesn't display to the user. not sure if you have a ticket for that yet. otherwise, seems to be working, but I'm also a regex noob. |
if you see problems like that it should definitely be a separate issue, or its too hard to track lots of things on one ticket. |
people often type like:
that should be picked up / filtered in the same way as normal
thanks @xx
use a regex to match in the whole input.
we may have to add another part to the "parseInput" section to handle these
The text was updated successfully, but these errors were encountered: