Added support for DELL U3818DW and PBP/PIP controls #71

aryoda · 2018-09-01T13:18:38Z

I have created a DB file for the monitor + extended the options.xml to support picture-by-picture (PBP/PIP) settings which split the screen into two parts an allow the visualisation of different input signals in each part (e. g. two computers).

See issue #70

For a better usability I have combined added the input source selection for every "split screen" into the same sub group.

The settings look like this:

Other monitors supporting PBP/PIB could reuse my control defintions in the options.xmlfile...

incl. vendor-specific VCP codes for split screen (PBP/PIP)

kravemir

There's a mistake in monitor's name. And, minor issues about source formatting. Please, keep formatting consistent with original formatting, for good readability.

kravemir · 2018-09-01T13:35:08Z

db/options.xml.in

@@ -375,6 +375,7 @@
 				<value id="component" name="Component"/>
 				<value id="s-video" name="S-Video"/>
 				<value id="composite" name="Composite"/>
+                                <value id="usb-c" name = "USB-C" />


Please, fix indentation, use tabs, as whole file uses tabs.

kravemir · 2018-09-01T13:36:46Z

db/options.xml.in

+				<value id="component" name="Component"/>
+				<value id="s-video" name="S-Video"/>
+				<value id="composite" name="Composite"/>
+                                <value id="usb-c" name = "USB-C" />


Please, fix indentation, use tabs only, and not mixture of tabs and spaces, as whole file uses tabs.

kravemir · 2018-09-01T13:37:01Z

db/options.xml.in

+				<value id="component" name="Component"/>
+				<value id="s-video" name="S-Video"/>
+				<value id="composite" name="Composite"/>
+                                <value id="usb-c" name = "USB-C" />


Please, fix indentation, use tabs only, and not mixture of tabs and spaces, as whole file uses tabs.

kravemir · 2018-09-01T13:40:03Z

db/monitor/DELA0F3.xml

@@ -0,0 +1,31 @@
+<?xml version="1.0"?>
+<!-- DELL UltraSharp 38 Monitor (Model 2017) -->
+<monitor name="DELL U8318DW" init="standard">


Probably, just mistake: DELL U8318DW

According to link, it's Dell U3818DW(DisplayPort), which matches the PR's name.

yes, this is a mistake, I will fix it - sharp eyes ;-)

kravemir · 2018-09-01T13:43:26Z

Thanks for creation of a PR. I did review it, and requested small changes. Otherwise, it seems fine.

kravemir · 2018-09-01T13:57:39Z

@aryoda, can you please test, how this works via other inputs - HDMI 1.4, HDMI 2.0, ...? Taking another look at: https://www.driverscloud.com/en/drivers/manufacturercat/90-4-28/dell-monitors and, this monitor seems to change ID based on input source.

aryoda · 2018-09-01T14:43:21Z

@kravemir Tabs are fixed now, thanks for keeping an eye on consistent code and configs!

can you please test, how this works via other inputs - HDMI 1.4, HDMI 2.0, ...?

How exactly can I test this? Since the HDMI inputs support older HDMI versions I guess I have to find an old computer with HDMI 1.4.

The OSD settings do not offer me a setting to fall back to an older HDMI version.

And: Which symptoms could happen? That the display is no longer recognized due to a changed Plug&Play-ID...?

kravemir · 2018-09-01T14:56:10Z

How exactly can I test this? Since the HDMI inputs support older HDMI versions I guess I have to find an old computer with HDMI 1.4.

Didn't see this monitor settings,.. but I guess, there's some option like Enable HDMI 2.0 -> True/False, or Suported HDMI version -> 1.4 / 2.0.

The OSD settings do not offer me a setting to fall back to an older HDMI version.

Aha, there's no such setting,.. Then, just test what you can.

And: Which symptoms could happen? That the display is no longer recognized due to a changed Plug&Play-ID...?

Based on the ID, is select monitor descriptor, that's why you named it DELA0F3.xml.

Probably, you'll just create new DELA???.xml, which would include DELA0F3.xml.

kravemir · 2018-09-01T15:03:11Z

db/monitor/DELA0F3.xml

+			<value id="PiP large"	value="0x22"/>
+			<value id="PiP small"	value="0x21"/>
+		</control>
+		<control id="maininputsource" type="list" address="0x60">


The address 0x60 is standard VESA, for: <control id="inputsource" ... . Why did you create another one?

Correct, this is for usability reasons within PBP/PIP to keep the sensible settings together. Interestingly the pure VESA config does not show the input setting by default. I could duplicate the control in the DELA0F3.xml setting as "Input Source" (standard VESA in "others") and in "PBP/PIP" ("main input source") to improve the usability even further (if gddccontrol does support this)...

kravemir · 2018-09-01T15:03:45Z

db/options.xml.in

+				<value id="PiP large"  name="PiP Large"/>
+				<value id="PiP small"  name="PiP Small"/>
+			</control>
+			<control id="maininputsource" type="list" name="Input Source Select (Main)">


Duplicates <control id="inputsource" ... . Is it necessary?

The problem lies in the config.xml: I would like to capture the allowed values for input sources only once and reuse them for PBP/PIP settings but they are bound within a group tag (were I do not want to place them - the group name "others" is definitely the last group I would search for the input source). And for a user to understand that the sub input source is in the PBP/PIP (sub) group but to set the input source for one of the split screens is in the "others" group under "input settings" is difficult to understand.

I will follow your usability proposals anyhow, please just suggest what you want and I push a new commit.

aryoda · 2018-09-01T16:04:25Z

@kravemir

can you please test, how this works via other inputs - HDMI 1.4, HDMI 2.0, ...?

Wow, good point, how did you know that?

I have used an HDMI-only notebook with Ubuntu 18.04 and ddccontrol.

According to the EDID readings of ddccontrol -p the U3818DW is saying DELA0F1 for HDMI 1.4 and DELA0F2 for HDMI 2.0 - I could not select the HDMI version manually but luckily the PBP mode seems to fall back to HDMI 1.4 (shown in the OSD info).

I will add two more config files including DELA0F3.xml (which is the ID for DisplayPort connections)
and send a new commit...

aryoda · 2018-09-01T16:08:21Z

NB: I could not test the EDID ID for DisplayPort over USB-C since I have no computer supporting this...

via HDMI 1.4, HDMI 2.0 and DisplayPort

aryoda · 2018-09-01T17:36:49Z

I have just seen in your link that DELL differentiates the EDID by the HDMI input port (HDMI1 or HDMI2).

I will push another commit to support all EDIDs later (tomorrow I guess)...

…ia manuall testing (except USB Type-c) DisplayPort, HDMI 1 + 2 with version 1.4 and 2.0, USB Type-C. USB Type-C could not be tested due to lack of test hardware availability.

aryoda · 2018-09-02T09:05:51Z

OK, here a short summary of the status quo:

I have added support for all known EDIDs now and tested them successfully (DP, HDMI1 + HDMI2 with v1.4 and v2.0) - except USB Type-C since I have no hardware for that

The usability decision for the input source (VCP code 0x60) is still open:

Where to put the (main) input source select (VCD code 0x60)?

In case of monitors without support for PBP/PIP it is in the "others" group currently
In case of monitors with PCP/PIP support (only DELL currently) it is in the PCP/PIP group together with the input source selector for the sub input(s). This is for usability reasons since in case of split screens a user often changes two input sources at once and changing the group in the menu for doing this means more clicks and is less intuitive (you have to understand that one input source is set in the "others" group while the other(s) in the "PCP/PIP" group.

On the other side: If you work with PBP "off" (= single screen) you do not expect input source selector in the "PBP/PIP" menu.

Possible solutions:

Move the PCP/PIP sub group to "others" and move add the sub input source selector into the same sub group as the current input source (in the "others" group)
Rename the PCP/PIP group to "Input Settings", move the "inputsource" control from "others" into this group and add the sub input source selector(s) from the PCP/PIP settings sub gruop into the "input settings" sub group too.

I will upload some screen shots for both propsals here later so that my proposals become clearer...

aryoda · 2018-09-02T09:33:54Z

Visual mock for option 1:

Visual mock for option 2:

IMHO

Option 1 is the least intrusive solution (no big changes) but "polutes" the "others" group.
Option 2 cleans-up the "others" group but also requires to refactor other controls in the input sub group of the "others" group (mainly "inputlevel" and "resolutionnotifier")

Other proposals welcome!

kravemir · 2018-09-02T09:53:16Z

I have added support for all known EDIDs now and tested them successfully (DP, HDMI1 + HDMI2 with v1.4 and v2.0) - except USB Type-C since I have no hardware for that

Great!

Where to put the (main) input source select (VCD code 0x60)?

Thank you for provided examples. I'm for option 2, create Input Settings group, and move/refactor Others -> Input Settings sub-group there. Probably, it makes sense to put it as the last group, but before Others ?

To keep compatibility with existing monitors, keep the id of inputsource, you may rename it to Input Source. And, use that instead of maininputsource.

And, other one can be inputsource_secondary, or inputsource_sub1 (keeps space for inputsource_sub2...).

Extra idea. I thought of control name override for specific monitors, or monitor specific (OSD) name. Especially, dynamic contrast has got many different OSD names. But, that requires much more effort.

So, PR's status from my point of view. Seems good, just remove duplicated control, and refactor/move this input settings controls, as you want to have all input settings (input source and PIP) in one place.

aryoda · 2018-09-02T10:09:34Z

OK, I will push the proposed changes later today, thanks for your feed back :-)

…Adjusted config for DELL U3818DW accordingly.

aryoda · 2018-09-02T11:12:14Z

Refactored now, the "release candidate" looks like this:

kravemir · 2018-09-02T11:40:28Z

Refactored now, the "release candidate" looks like this:

Looks good 👍

kravemir · 2018-09-02T11:44:52Z

I'll do (probably) final PR review after I'll arrive home, and merge it, if everything's fine.

aryoda · 2018-09-02T11:50:14Z

I'll do (probably) final PR review after I'll arrive home, and merge it, if everything's fine.

Perfect (no need to hurry, I have a local installation now).

Thanks for your support :-)

kravemir · 2018-09-02T13:45:30Z

I have merged the PR. I have had taken a look at the code. It seems fine, hope I didn't miss something.

The monitor seems tempting, though.. out of my price range. Do you use such "wow" monitor for work (on Linux), or just for personal stuff / hobby?

Added support for DELL U3818DW and PBP/PIP controls

2040401

incl. vendor-specific VCP codes for split screen (PBP/PIP)

kravemir suggested changes Sep 1, 2018

View reviewed changes

kravemir added the monitor label Sep 1, 2018

fixed monitor name typo. replaced white spaces by tabs.

56a5eac

kravemir approved these changes Sep 1, 2018

View reviewed changes

kravemir reviewed Sep 1, 2018

View reviewed changes

Added support for different DELL U3818DWH EDID IDs

cb220ac

via HDMI 1.4, HDMI 2.0 and DisplayPort

Added DB config files for all known EDIDs of DELL U3818DW. Verified v…

1f04516

…ia manuall testing (except USB Type-c) DisplayPort, HDMI 1 + 2 with version 1.4 and 2.0, USB Type-C. USB Type-C could not be tested due to lack of test hardware availability.

Refactored PBP and input settings into a new group "Input settings". …

91d0c2b

…Adjusted config for DELL U3818DW accordingly.

kravemir merged commit d294da1 into ddccontrol:master Sep 2, 2018

kravemir mentioned this pull request Sep 2, 2018

DELL U3818DW with proposed XML config file and option file changes #70

Closed

kravemir mentioned this pull request Oct 4, 2018

Add Dell U2410f #75

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for DELL U3818DW and PBP/PIP controls #71

Added support for DELL U3818DW and PBP/PIP controls #71

aryoda commented Sep 1, 2018

kravemir left a comment

kravemir Sep 1, 2018

kravemir Sep 1, 2018

kravemir Sep 1, 2018

kravemir Sep 1, 2018

aryoda Sep 1, 2018

kravemir commented Sep 1, 2018

kravemir commented Sep 1, 2018

aryoda commented Sep 1, 2018

kravemir commented Sep 1, 2018

kravemir Sep 1, 2018

aryoda Sep 1, 2018

kravemir Sep 1, 2018

aryoda Sep 1, 2018

aryoda commented Sep 1, 2018

aryoda commented Sep 1, 2018

aryoda commented Sep 1, 2018

aryoda commented Sep 2, 2018

aryoda commented Sep 2, 2018

kravemir commented Sep 2, 2018

aryoda commented Sep 2, 2018

aryoda commented Sep 2, 2018

kravemir commented Sep 2, 2018 •

edited

Loading

kravemir commented Sep 2, 2018

aryoda commented Sep 2, 2018

kravemir commented Sep 2, 2018

Added support for DELL U3818DW and PBP/PIP controls #71

Added support for DELL U3818DW and PBP/PIP controls #71

Conversation

aryoda commented Sep 1, 2018

kravemir left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kravemir commented Sep 1, 2018

kravemir commented Sep 1, 2018

aryoda commented Sep 1, 2018

kravemir commented Sep 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aryoda commented Sep 1, 2018

aryoda commented Sep 1, 2018

aryoda commented Sep 1, 2018

aryoda commented Sep 2, 2018

aryoda commented Sep 2, 2018

kravemir commented Sep 2, 2018

aryoda commented Sep 2, 2018

aryoda commented Sep 2, 2018

kravemir commented Sep 2, 2018 • edited Loading

kravemir commented Sep 2, 2018

aryoda commented Sep 2, 2018

kravemir commented Sep 2, 2018

kravemir commented Sep 2, 2018 •

edited

Loading