Skip to content

Commit

Permalink
Consistently use --arg instead of -arg
Browse files Browse the repository at this point in the history
  • Loading branch information
rhansen committed May 14, 2024
1 parent 8ac5751 commit 542bb28
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,13 @@ This issue arises when using the `use` parameter in the config and using one of

## TROUBLESHOOTING

1. enable debugging and verbose messages: ``$ ddclient -daemon=0 -debug -verbose -noquiet``
1. enable debugging and verbose messages: ``$ ddclient --daemon=0 --debug --verbose --noquiet``

2. Do you need to specify a proxy?
If so, just add a ``proxy=your.isp.proxy`` to the ddclient.conf file.

3. Define the IP address of your router with ``fw=xxx.xxx.xxx.xxx`` in
``/etc/ddclient/ddclient.conf`` and then try ``$ ddclient -daemon=0 -query`` to see if the router status web page can be understood.
``/etc/ddclient/ddclient.conf`` and then try ``$ ddclient --daemon=0 --query`` to see if the router status web page can be understood.

4. Need support for another router/firewall?
Define the router status page yourself with: ``fw=url-to-your-router``'s-status-page ``fw-skip=any-string-preceding-your-IP-address``
Expand All @@ -177,10 +177,10 @@ This issue arises when using the `use` parameter in the config and using one of
OR
Send me the output from:
``$ ddclient -geturl {fw-ip-status-url} [-login login [-password password]]``
``$ ddclient --geturl {fw-ip-status-url} [--login login [--password password]]``
and I'll add it to the next release!

ie. for my fw/router I used: ``$ ddclient -geturl 192.168.1.254/status.htm``
ie. for my fw/router I used: ``$ ddclient --geturl 192.168.1.254/status.htm``

5. Some broadband routers require the use of a password when ddclient
accesses its status page to determine the router's WAN IP address.
Expand Down Expand Up @@ -229,7 +229,7 @@ In my case, it is named dhcpcd-eth0.exe and contains the lines:
#!/bin/sh
PATH=/usr/bin:/root/bin:${PATH}
logger -t dhcpcd IP address changed to $1
ddclient -proxy fasthttp.sympatico.ca -wildcard -ip $1 | logger -t ddclient
ddclient --proxy fasthttp.sympatico.ca --wildcard --ip $1 | logger -t ddclient
exit 0
```

Expand Down
6 changes: 3 additions & 3 deletions ddclient.in
Original file line number Diff line number Diff line change
Expand Up @@ -1867,14 +1867,14 @@ sub init_config {
}
$options{$name} = $var;
}
## determine hosts specified with -host
## determine hosts specified with --host
my @hosts = ();
if (exists $opt{'host'}) {
foreach my $h (split_by_comma($opt{'host'})) {
push @hosts, $h;
}
}
## and those in -options=...
## and those in --options=...
if (exists $options{'host'}) {
foreach my $h (split_by_comma($options{'host'})) {
push @hosts, $h;
Expand All @@ -1901,7 +1901,7 @@ sub init_config {

## sanity check
if (defined $opt{'host'} && defined $opt{'retry'}) {
fatal("options -retry and -host (or -option host=..) are mutually exclusive");
fatal("options --retry and --host (or --option host=..) are mutually exclusive");
}

## determine hosts to update (those on the cmd-line, config-file, or failed cached)
Expand Down

0 comments on commit 542bb28

Please sign in to comment.