-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turned HTML version into self-saving document #36
Conversation
c48516e
to
01fb5b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in chrome, it works fine. What do you think about adding the name of the context to the download link? (As for now, all downloads are called bounded-context-canvas.html
.)
Other 2 points which could be improved on the Html version, if you want (regarding the content, not the self-saving functionality):
- at the bottom of the page, the references to the different relationships are incomplete.
- missing space between Source and DocumentationDDD Crew on GitHub: Bounded Context Canvas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Excellent idea; done. I've fixed some of the details you mentioned in 830e25e, but I'm a little uncertain about the list of relationships there - in part because I'm not quite clear on the original author's intent. So I've opted not to change any content here. (My guess is that the HTML version might be due for a little overhaul anyway? 🤷 ) |
this is fairly crude, particulary because for now we only support text fields (both `input[type=text]` and `textarea`) and radio buttons we might also use file-system APIs <https://web.dev/file-system-access/> where supported, but that seems overkill for the moment
we do _not_ want to persist the `hidden` and `href` attributes' state if this were any more complex, we might need proper encapsulation - but for now that's YAGNI
plus proper spacing
Hello @FND
Yes, I agree, you did enough! Thank you. |
as suggested in #33
NB: This has not been heavily tested, so a thorough review seems necessary.