-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(image): updates colored image of ddd modeling process with arrows #33
Conversation
Amazing! |
I like the coloring too, it makes things "jumps out" more into one's eyes. Some little things I would propose to "refactor":
Anyways, these are just small things (and maybe some are too literal and focused on the "tools" we use on each phase... but those popped out when I was looking at the colored diagram). I think in general color really highlights things in the diagram, good job @jlasoc1! |
I'll look into this, thank you for the feedback, sorry the late reply I'm in Chile timezone hahaha :) |
Hey folks, the PR was updated from the feedback comments of @emgsilva 😄 |
Looks good to me - I like it! 👍 |
I love that colored picture! 🤩 Thanks again @jlasoc1 ! Do you think it would be possible to add the subtitle sentence that was on the previous version? I think it adds some useful context on how to use the process that avoid people being too dogmatic about it. Thanks! |
Honestly, I think it's great. It's much better and more appealing with colour in my opinion. If there was 1 thing I would change it would be the arrows, maybe use a slightly lighter grey and a bit of opacity so you can see the arrows overlapping a bit. Is it too soon to ask @jlasoc1 to give this repo a makeover as well 😅? https://github.com/ddd-crew/welcome-to-ddd EDIT: there is some opacity and you can see the arrows are overlapping 😂 Me stupid. |
@jlasoc1 feel free to merge this whenever you are ready and have finished reviewing the feedback. You should have permissions to do that. |
Wooow @NTCoding that repo looks amazing for a makeover hahaha, I'll take a look. My design skills have limits hahahah |
I'll merge the file @Max-Git if you want me to do any other change I can definitely post another PR, we can improve this as much as we want 🥳 |
Many thanks @jlasoc1 !!! |
Thanks @jlasoc1 this looks amazing! |
Sumary
This PR updates the domain-driven design starter process diagram with a colored one, with grey arrows. I'm opening this PR because I talked to @Max-Git and he liked the colored version and asked me to submit a PR
Where the change occurs
README.md file
Does it have test?
N/A