New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all IMAP message headers if needed. Remove Doctrine dependency. #29
Conversation
…parameter array. Performace improvement for large message collections.
Your support for But is the And can you please update your code to conform to the PSR-2 coding standards? Thanks! |
|
$headers = \imap_header($this->stream, $this->messageNumber); | ||
$this->headers = new Message\Headers($headers); | ||
|
||
if($rawHeaders) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space after if
All right, let's get rid of the
Actually only the missing spaces after |
👍 |
{ | ||
$this->rawHeaders = $rawHeaders; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this rawHeaders
useful? I don’t see a way to access it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, $rawHeaders
contains extra MIME headers that $headers
does not contain. I honestly don't remember if I was extending this class or just marked this as public or what.
@ddeboer +1 |
Implemented in #202 due to heavily refactored code. |
(Background: I deal with a lot of messages which have custom headers.)
This commit solves two problems:
imap_header()
function.