Message headers: skip records with unsupported characters #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you also add tests please? |
|
@Slamdunk I'm generating test 😅 |
|
Nice. You can also run the build locally, so the development feedback loop gets much faster, see https://github.com/ddeboer/imap#contributing-run-the-build-locally |
Slamdunk
requested changes
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
=========================================
Coverage 95.57% 95.58%
- Complexity 356 357 +1
=========================================
Files 45 45
Lines 837 838 +1
=========================================
+ Hits 800 801 +1
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@Slamdunk I didn't change anything in AbstractPart.php where pipeline fails.... 😅 |
Slamdunk
approved these changes
Aug 26, 2022
Slamdunk
changed the title
saintsloth
pushed a commit
to saintsloth/imap
that referenced
this pull request
Oct 27, 2022
…eboer#546)" This reverts commit c8e26a0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #545