-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-domain setups and create a proxy middleware for each domain #40
base: main
Are you sure you want to change the base?
Conversation
@mmunz Thanks for PR. Could you some steps here I can follow so I can test it? |
@tyler36 i created a ddev test setup here: https://github.com/mmunz/browsersynctest/tree/multiple-domain-support It is a ddev setup with an additional hostname and two docroots. To test it do:
|
I had a look at the PR today. After running it, I opened Changes made to Is that the expected behavior? |
@mandrasch would this have helper for your use case (#27) ? |
@tyler36 i have to look deeper into this, but i suspect this is same strange caching issue (browser cache or even the http-proxy-middleware). |
Can't really say. While reading through the steps provided by @mmunz I just noticed that I never used the I just installed ddev-browsersync to open up the port via the docker-compose file...In LaravelMix browsersync was controlled by the package itself (https://laravel-mix.com/docs/6.0/browsersync), see also my answer #27 (comment). Guess my issue was more a docs-related one to LaravelMix integration. Much success solving this! |
@tyler36 The problem was, that in the demo project the public folder was not properly watched. I've updated https://github.com/mmunz/browsersynctest/tree/multiple-domain-support to watch for files in public in browser-sync.js now. |
Sorry for the delayed response. |
@tyler36 well, it's the best solution for the problem i came up with. I'm also using it in my own multidomain projects. The downside is that it adds a bit of complexity. But i'd love to hear from others, if they use this approach and if it works, or if there exist better solutions. |
No description provided.