Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update add-on after migration to ddev org #2

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

stasadev
Copy link
Member

The Issue

How This PR Solves The Issue

  1. I want to become a maintainer because I use OpenSearch (and have my own config), but I never knew about this add-on.
  2. Update tests.yml to the latest one.
  3. Update docker-compose.opensearch.yaml:
  • remove version, networks, links as not needed
  • remove hostname - I never actually set this setting, and didn't see it in the official DDEV add-ons
  • rename ES_JAVA_OPTS to OPENSEARCH_JAVA_OPTS
  • use cluster.name and node.name from the official docs.
  • remove SERVER_NAME from opensearch-dashboards - I don't know why this needed.
  • add healthcheck

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from cmuench April 23, 2024 16:43
@stasadev
Copy link
Member Author

@cmuench, let me know if you agree with any of these changes.

This will be a major 2.0.0 release, because I made some changes to the names of some variables (according to the official OpenSearch docs) and I don't know if it's compatible with existing installations of this add-on.

Copy link
Collaborator

@cmuench cmuench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@stasadev stasadev merged commit b101720 into main Apr 23, 2024
2 checks passed
@stasadev stasadev deleted the 20240423_stasadev_update_addon branch April 23, 2024 18:52
@stasadev
Copy link
Member Author

Thanks and one more thing that I noticed just now, there is no LICENSE file.
Is it okay to use this one?
https://github.com/ddev/ddev-addon-template/blob/main/LICENSE

@cmuench
Copy link
Collaborator

cmuench commented Apr 23, 2024

Thanks and one more thing that I noticed just now, there is no LICENSE file. Is it okay to use this one? https://github.com/ddev/ddev-addon-template/blob/main/LICENSE

I am a big fan of MIT license but the Apache license is also OK for me. If it's the default for ddev addons then let's use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants