Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.1 Release Checklist #21

Closed
7 tasks done
rickmanelius opened this issue Sep 6, 2017 · 11 comments
Closed
7 tasks done

v0.1 Release Checklist #21

rickmanelius opened this issue Sep 6, 2017 · 11 comments
Assignees
@rfay @cyberswat
Labels
actionable needs automated tests needs docs
Milestone
v0.1.0

Comments

@rickmanelius
Copy link
Contributor

rickmanelius commented Sep 6, 2017 •
edited by rfay
Loading

Remaining actions:

  • Review release (product owner)
  • Approve release (product owner and release manager)
  • Create binaries (any DRUD maintainer)
  • Draft release notes (release manager)
  • Draft additional announcements for blog, newsletter, etc (not applicable at the moment)
  • Create release (release manager)
  • Update any package managers to point to new release (release manager)

For additional background information, please see our Product Release instructions here.
@rickmanelius rickmanelius added this to the v0.1 milestone Sep 6, 2017
@rickmanelius rickmanelius self-assigned this Sep 6, 2017
@rickmanelius
Copy link
Contributor Author

rickmanelius commented Oct 23, 2017 •
edited
Loading

This is a snapshot of my testing doc to be used and updated during my testing process.

ddev-ui v0.1 Review

Executive Summary

Based on the following analysis, ddev-ui v0.1 is NOT YET ready for release.

Milestone Overview

The intention of this milestone (see the roadmap to v01.0 https://github.com/drud/ddev-ui/wiki/roadmap) is to provide the basic functionality of adding, viewing, and toggling between apps. Areas of focus here are as follows:

  • Browse all active apps.
  • Start, stop, and restart apps.
  • Add an app from a starting distribution

Testing

Performed by Rick Manelius as of 2017-11-21

Hardware

I’m using a laptop with the following high level specifications:

  • MacBook Pro: Retina 15-inch Mid 2015
  • 2.2 Ghz Intel Core i7
  • 16 GB 1600 MHz DDR3 RAM
  • 250 GB Hard Drive
  • macOS Sierra 10.31.1

Software Setup

  • Xcode
  • Go 1.9
  • Docker 17.09.0-ce
  • Git 2.13.5

Repositories Used

Preparation

  • Run make clean && make darwin
  • Verified I have macOS and DMG generated
  • Opened app and verified

Results

To Test

Actively Testing

  • Basic App Browsing (ddev-ui/issues/15)
    • Ran ddev list to see that I have a Druapl 756 site operational.

Works

Fails

Decisions

  • Based on the following analysis, ddev-ui v0.1 is NOT YET ready for release.

Recommendations

@rickmanelius
Copy link
Contributor Author

Updating comment to better connect in features and repos/versions used.

@rickmanelius
Copy link
Contributor Author

Bumping this back. This is blocked by issues w/codebase needing to get rebased on two of the referenced issues before I can proceed with the review.

@rickmanelius rickmanelius removed their assignment Dec 6, 2017
@rickmanelius rickmanelius mentioned this issue Dec 12, 2017
Closed
1 task
@rickmanelius
Copy link
Contributor Author

FWIW, this is nearly there. We're waiting on a test/code review for the Add CMS from Distro item once @andrew-c-tran gives the thumbs up to @rfay that it's ready to review. I'm fully aware there are going to be quite a few follow-up issues, but the core functionality is working and some of the changes are scattered about different PRs. Still, the way out seems like getting WIP reduced so that we reduce sprawl and make reviews tenable and start having a stable foundation for tests.

@rickmanelius
Copy link
Contributor Author

This is a snapshot of my testing doc to be used and updated during my testing process.

ddev-ui v0.1 Review

Executive Summary

Based on the following analysis, ddev-ui v0.1 is NOT YET ready for release.

Milestone Overview

The intention of this milestone (see the roadmap to v01.0 https://github.com/drud/ddev-ui/wiki/roadmap) is to provide the basic functionality of adding, viewing, and toggling between apps. Areas of focus here are as follows:

  • Browse all active apps.
  • Start, stop, and restart apps.
  • Add an app from a starting distribution

Testing

Performed by Rick Manelius as of 2017-11-21

Hardware

I’m using a laptop with the following high level specifications:

  • MacBook Pro: Retina 15-inch Mid 2015
  • 2.2 Ghz Intel Core i7
  • 16 GB 1600 MHz DDR3 RAM
  • 250 GB Hard Drive
  • macOS Sierra 10.31.1

Software Setup

  • Xcode
  • Go 1.9
  • Docker 17.09.0-ce
  • Git 2.13.5

Repositories Used

Preparation

  • Run make clean && make darwin

  • Verified I have macOS and DMG generated

  • Opened app and verified

Results

Works

  • Basic App Browsing (ddev-ui/issues/15)
    • Ran ddev list to see that I have both a Druapl 7.56 and WordPress 4.9 site operational.
    • Opened ddev-ui.app from /dist/mac
    • I observe both apps present.
    • Comparing against our updated wireframe here Basic App Browsing #15 (comment).
      • The "Sitename" is there and centered.
      • The "Sitename" is clickable to open up a browser at the HTTP version.
      • The app "Thumbnail" is there and centered.
      • The "Sitename" is clickable to open up a browser at the HTTP version.
      • The app "Status" is there but it's laying on top of the app thumbnail without a knockout.
    • Issues
      • No tooltips are present for start, stop, or describe. I discussed with Andrew and this is in another branch.
    • The apps are visible at all 3 breakpoints.
    • CONFIRMED w/caveats that need to be addressed in follow-up issues (see recommendations).
  • Start/Stop/Restart (ddev-ui/issues/13)
    • Ran ddev list to see that I have both a Druapl 7.56 and WordPress 4.9 site operational.
    • Opened ddev-ui.app from /dist/mac
    • Clicking the "Start" button when stopped shows the status update and then puts the site into a live status.
    • Clicking the "Stop" button when running shows the status update and then puts the site into a stopped status.
    • Running ddev rm from the CLI instantly removes this from the app.
    • Clicking the "Restart" button in the utility menu did cycle through the stopped status before coming back up.
    • CONFIRMED w/caveats that need to be addressed in follow-up issues (see recommendations).

Needs Code / Rest Review

  • Add App from Distribution (ddev-ui/issues/14)
    • Opened ddev-ui.app from /dist/mac
    • Clicked on the + in the upper right corner.
    • Testing WordPress
      • App: WordPress
      • Name: JunkerWP
      • Install: ~/Desktop
      • Clicked "Create Site"
      • I see a spinner appear and the window greys out.
      • I am prompted to add my username and password.
      • I see activity go through with various status updates.
      • I see JunkerWP appear.
      • I can click and confirm a WordPress site is there.
      • I go to the terminal and can confirm a JunkerWP folder is there and a wordpress folder is within that.
    • Testing Drupal 7
      • App: Drupal 7
      • Name: JunkerD7
      • Clicked "Create Site"
      • I see a spinner appear and the window greys out.
      • I am prompted to add my username and password.
      • I see activity go through with various status updates.
      • I see JunkerD7 appear.
      • I can click and confirm a Drupal 7 site is there.
      • I go to the terminal and can confirm a JunkerD7 folder is there and a "drupal-7.56" is within that.
    • Testing Drupal 8
      • App: Drupal 8
      • Name: JunkerD8
      • Clicked "Create Site"
      • I see a spinner appear and the window greys out.
      • I am prompted to add my username and password.
      • I see activity go through with various status updates.
      • I see JunkerD7 appear.
      • I can click and confirm a Drupal 8 site is there.
      • I go to the terminal and can confirm a JunkerD8 folder is there and a "drupal-8.4.3" is within that.
      • I can confirm the vendor directory is populated
    • CONFIRMED

Decisions

  • Based on the following analysis, ddev-ui v0.1 is NOT YET ready for release.

Recommendations

  • NPM upgrade instructions after running make darwin for ddev-ui. I noted that after running make clean && make darwin that I had an npm update prompt. I'm not entirely sure it's needed, but it might be something we provide some details on to give end-users some guidance. This is particular true given that these instructions may or may not be compatible with a brew install for macOS user.
  • ddev list order should probably sort alphabetically. It's not a problem but just something I noticed.
  • Design/Style
    • We need to address the dark blue links on a black background.
    • We discussed a knockout background for the app status in the body section of the card.
    • We should either a) cross over to the smallest breakpoint earlier or, ideally, b) go to two apps across. I'll have to look more closely for the exact pixel cutoff, but ideally the 3 buttons shouldn't scrunch into two rows ever.
  • Link destination. We default to the HTTP but should probably promote security by pushing to the HTTPS.
  • Transition States. I do note that the start and stop button are present while it's starting. It might be better to prevent compulsive double/triple clicking to remove both and update the status immediately OR put some sort of spinner icon in it's place that's NOT clickable but basically alerts the user that something is happening. Hell, it might not be a bad idea to place a giant spinner as an overlay. There is also the situation where 4 buttons appear at the same time and that kinda breaks the goal of keeping it to a max of three across. Clicking "restart" has a similar affect because it takes a few seconds without any visual queues that something is happening
  • Stopped Status Links. It's probably worth changing the links from active to just text if the sites are in the stopped state. Alternatively, we can potentially warn the user that the site is stopped and to trigger a start.
  • Add from distribution directory. Right now we're adding what I feel is an unnecessary parent folder. When a user specifies a folder, I would prefer that this is the parent folder and we're not pushing it one level inside the CMS name+version version (e.g. "drupal-8.4.3") folder.

@rickmanelius rickmanelius mentioned this issue Dec 12, 2017
Closed
@rickmanelius
Copy link
Contributor Author

ddev-ui v0.1 Review

Executive Summary

Based on the following analysis, ddev-ui v0.1 is ready for release.

Milestone Overview

The intention of this milestone (see the roadmap to v01.0 https://github.com/drud/ddev-ui/wiki/roadmap) is to provide the basic functionality of adding, viewing, and toggling between apps. Areas of focus here are as follows:

  • Browse all active apps.
  • Start, stop, and restart apps.
  • Add an app from a starting distribution

Testing

Performed by Rick Manelius as of 2018-01-02

Hardware

I’m using a laptop with the following high level specifications:

  • MacBook Pro: Retina 15-inch Mid 2015
  • 2.2 Ghz Intel Core i7
  • 16 GB 1600 MHz DDR3 RAM
  • 250 GB Hard Drive
  • macOS Sierra 10.31.1

Software Setup

  • Xcode
  • Go 1.9
  • Docker 17.12.0-ce-rc4
  • Git 2.13.6

Repositories Used

Preparation

  • Run make clean && make darwin
  • Verified I have macOS and DMG generated
  • Opened app and verified

Results

Works

  • Basic App Browsing (ddev-ui/issues/15)
    • Ran ddev list to see that I have both a Druapl 7.56 and WordPress 4.9 site operational.
    • Opened ddev-ui.app from /dist/mac
    • I observe both apps present.
    • Comparing against our updated wireframe here Basic App Browsing #15 (comment).
      • The "Sitename" is there and centered.
      • The "Sitename" is clickable to open up a browser at the HTTP version.
      • The app "Thumbnail" is there and centered.
      • The "Sitename" is clickable to open up a browser at the HTTP version.
      • The app "Status" is there.
    • Issues
      • No tooltips are present for start, stop, or describe. I discussed with Andrew and this is in another branch.
    • The apps are visible at all 3 breakpoints.
    • CONFIRMED w/caveats that need to be addressed in follow-up issues (see recommendations).
  • Start/Stop/Restart (ddev-ui/issues/13)
    • Ran ddev list to see that I have both a Druapl 7.56 and WordPress 4.9 site operational.
    • Opened ddev-ui.app from /dist/mac
    • Clicking the "Start" button when stopped shows the status update and then puts the site into a live status.
    • Clicking the "Stop" button when running shows the status update and then puts the site into a stopped status.
    • Running ddev rm from the CLI instantly removes this from the app.
    • Clicking the "Restart" button in the utility menu did cycle through the stopped status before coming back up.
    • CONFIRMED w/caveats that need to be addressed in follow-up issues (see recommendations).
  • Add App from Distribution (ddev-ui/issues/14)
    • Opened ddev-ui.app from /dist/mac
    • Clicked on the + in the upper right corner.
    • Received a prompt about needing escalated priveleges.
    • See a modal about "start fresh from a CMS template"
    • Testing WordPress
      • App: WordPress
      • Name: JunkerWP
      • Install: ~/Desktop
      • Clicked "Create Site"
      • I am prompted to add my username and password.
      • I see a spinner appear and the window greys out.
      • I see activity go through with various status updates.
      • I see JunkerWP appear.
      • I can click and confirm a WordPress site is there.
      • I go to the terminal and can confirm a JunkerWP folder is there with WordPress 4.9.1 there.
    • Testing Drupal 7
      • App: Drupal 7
      • Name: JunkerD7
      • Install: ~/Desktop
      • Clicked "Create Site"
      • I am prompted to add my username and password.
      • I see a spinner appear and the window greys out.
      • I see activity go through with various status updates.
      • I see JunkerWP appear.
      • I can click and confirm a Drupal 7 site is there.
      • I go to the terminal and can confirm a JunkerD7 folder is there with Drupal 7.56 there.
    • Testing Drupal 8
      • App: Drupal 8
      • Name: JunkerD8
      • Install: ~/Desktop
      • Clicked "Create Site"
      • I am prompted to add my username and password.
      • I see a spinner appear and the window greys out.
      • I see activity go through with various status updates.
      • I see JunkerWP appear.
      • I can click and confirm a Drupal 8 site is there.
      • I go to the terminal and can confirm a JunkerD8 folder is there with Drupal 8.4.3 there.
    • CONFIRMED

Decisions

  • Based on the following analysis, ddev-ui v0.1 is ready for release.

Recommendations

  • ddev list order should probably sort alphabetically. It's not a problem but just something I noticed.
  • Design/Style
    • We should either a) cross over to the smallest breakpoint earlier or, ideally, b) go to two apps across. I'll have to look more closely for the exact pixel cutoff, but ideally the 3 buttons shouldn't scrunch into two rows ever.
  • Link destination. We default to the HTTP but should probably promote security by pushing to the HTTPS.
  • Transition States. I do note that the start and stop button are present while it's starting. It might be better to prevent compulsive double/triple clicking to remove both and update the status immediately OR put some sort of spinner icon in it's place that's NOT clickable but basically alerts the user that something is happening. Hell, it might not be a bad idea to place a giant spinner as an overlay. There is also the situation where 4 buttons appear at the same time and that kinda breaks the goal of keeping it to a max of three across. Clicking "restart" has a similar affect because it takes a few seconds without any visual queues that something is happening
  • Stopped Status Links. It's probably worth changing the links from active to just text if the sites are in the stopped state. Alternatively, we can potentially warn the user that the site is stopped and to trigger a start.
  • Somehow we've managed to add up to two security prompts per CMS add. I don't know why that's necessary but I'm sure we can figure out how to reduce as part of a larger issue on ddev regarding /etc/hosts file modifications.

@rickmanelius
Copy link
Contributor Author

This is approved. However, since this project is not open sourced, I leave it to the group on how much it makes sense to create a binary and release notes. We should absolutely tag v0.1.0 so that we can base existing PRs off of a known target.

@rickmanelius
Copy link
Contributor Author

Adding @rfay or @cyberswat to address the release itself.

@rfay
Copy link
Member

rfay commented Jan 2, 2018

Created https://github.com/drud/ddev-ui/releases/tag/v0.1.0

@rfay rfay closed this as completed Jan 2, 2018
@rfay rfay reopened this Jan 2, 2018
@rfay
Copy link
Member

rfay commented Jan 2, 2018

Reopened, I guess there are still checkboxes to be checked.

@rfay
Copy link
Member

rfay commented Jan 2, 2018

No, I guess there aren't :)

@rfay rfay closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rfay rfay

@cyberswat cyberswat

Labels
actionable needs automated tests needs docs
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
4 participants
@rfay @cyberswat @rickmanelius @andrew-c-tran