Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic App Browsing #15

Closed
1 task
rickmanelius opened this issue Aug 25, 2017 · 5 comments
Closed
1 task

Basic App Browsing #15

rickmanelius opened this issue Aug 25, 2017 · 5 comments

Comments

@rickmanelius
Copy link
Contributor

rickmanelius commented Aug 25, 2017

What happened (or feature request):

Feature Request

What you expected to happen:

  • On any screen, there is a home button that, when clicked, brings them back to apps dashboard.
  • All apps that the ddev CLI is aware of (from running ddev list) is available.
  • For each app, the sitename and an image representing the app type is displayed.
  • Clicking the site name or the image brings them to the app screen.
  • There is a button to open up the site directly from the apps dashboard.

Blockers

  • @rickmanelius to provide links to images to use for default state.
@andrew-c-tran
Copy link
Contributor

what were we looking for in terms of "site dashboard"? right now the start/stop/restart and soon remove buttons will be on the main card. the url and path are both included and clickable on the main card as well. Are we calling the describe functionality (which will eventually open in a modal) the dashboard? or is that a separate story? In short, with the current functionality of the proptype, is this story considered complete?

@rickmanelius
Copy link
Contributor Author

Given some of the feedback here #8, while the basic functionality of this issue is in place, I can either update this ticket to reflect the updated requests or we can do it here. I'll start updating the request here and if we decide it's worth splitting out I'm happy to do whatever makes us most effective at a team.

@andrew-c-tran
Copy link
Contributor

andrew-c-tran commented Oct 23, 2017 via email

@rickmanelius
Copy link
Contributor Author

Updates from our conversation:

  • We're removing the concept of a dedicated app page versus the "dashboard". Most information relevant to the app can be surfaced by essentially pulling up the information from the ddev describe modal overlay. If we later find this approach to be problematic, we can discuss a means of toggling back and forth.
  • There are a lot of small changes we discussed on the buttons and overall structure of each app card. Attached is the overall goal (hand drawn and I can clean-up).
  • For the purpose of this issue, I think we can define done related to 1) apps show up when ddev list shows them 2) app status 3) CMS screenshot default of app type 4) site name and CMS image are clickable to the URL and 5) buttons and arrangement are in the proper place (whether or not they function at this time).

handdrawn-app-card-v1

@rickmanelius
Copy link
Contributor Author

Testing Results

  • Ran ddev list to see that I have both a Druapl 7.56 and WordPress 4.9 site operational.
  • Opened ddev-ui.app from /dist/mac
  • I observe both apps present.
  • Comparing against our updated wireframe here Basic App Browsing #15 (comment).
    • The "Sitename" is there and centered.
    • The "Sitename" is clickable to open up a browser at the HTTP version.
    • The app "Thumbnail" is there and centered.
    • The "Sitename" is clickable to open up a browser at the HTTP version.
    • The app "Status" is there but it's laying on top of the app thumbnail without a knockout.
  • Issues
    • No tooltips are present for start, stop, or describe. I discussed with Andrew and this is in another branch.
  • Clicking the "Start" button when stopped shows the status update and then puts the site into a live status.
  • Clicking the "Stop" button when running shows the status update and then puts the site into a stopped status.
  • The apps are visible at all 3 breakpoints.
  • Running ddev rm from the CLI instantly removes this from the app.

I'm fine with accepting this as is because I believe (perhaps correctly or incorrectly) that we're in a situation where there is a bunch of WIP across PRs, which makes this difficult to review accurately for things slightly beyond the core functionality of start, stop, and also the listing of each app. Given the PR was already merged and we're trying to clear WIP, I'll consider this issue closed. I will add my follow-up recommendations in the v0.1 release review here #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants