Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwilling to remove 'xhprof_prepend.php' because it does not have #ddev-generated in it: #11

Closed
rfay opened this issue Nov 7, 2023 · 2 comments · Fixed by #28
Closed

Comments

@rfay
Copy link
Member

rfay commented Nov 7, 2023

I removing the add-on I got the message
Unwilling to remove '/Users/rfay/workspace/d10/.ddev/xhprof/xhprof_prepend.php' because it does not have #ddev-generated in it: signature was not found in file /Users/rfay/workspace/d10/.ddev/xhprof/xhprof_prepend.php; you can manually delete it if it is safe to delete.
I saw a comment about this in xhprof_prepend.php added here, but I don't think this is a good approach, we should figure out a proper way to add the xhprof_prepend.php that you want, or figure something out.

@tyler36
Copy link
Collaborator

tyler36 commented Nov 8, 2023

For reference: .ddev/xhprof/xhprof_prepend.php @ 0.2

<?php

// ddev's built in xhprof handler breaks our own. If we leave ddev-generated in
// this file, then ddev xhprof will overwrite this file.
return;

@rfay
Copy link
Member Author

rfay commented Nov 8, 2023

In the current setup, it may be worth considering deleting this in removal_actions. But this really is problematic.

How about overriding the docker-compose to remove the mount of .ddev/xhprof? That's hard, but in latest docker-compose I think there's a way to do it. It is hard though. Or it's possible we need some feature in DDEV to turn off the mounting or do it another way.

@tyler36 tyler36 mentioned this issue Nov 10, 2023
tyler36 added a commit that referenced this issue Apr 26, 2024
tyler36 added a commit that referenced this issue Apr 26, 2024
tyler36 added a commit that referenced this issue Apr 26, 2024
tyler36 added a commit that referenced this issue May 28, 2024
tyler36 added a commit that referenced this issue May 28, 2024
* Claim and return ownership of xhprof_prepend.php
Fixes #11

* use traditional HEREDOC delimiter

---------

Co-authored-by: tyler36 <7234392+tyler36@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants