fix: make tests work again, bump GitHub dependencies #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
added a commit
that referenced
this pull request
Jun 5, 2024
stasadev
added a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Tests are broken:
I investigated this and found that it is a problem in
withastro/action@v2I opened a PR there, but don't know if it is going to be merged soon:
How This PR Solves The Issue
yarn.lockfiles fromnode_modulesdirectory before runningwithastro/action@v2. (This workaround can be removed later.)actions/checkoutandactions/setup-nodetov4.withastro/action@v2usesnode-version, but we do not set it explicitly - fixed.Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes