-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update codespaces install, fixes #85 #86
Conversation
I failed again and did this on my fork. |
Please take a look @mandrasch |
Hey! Sure thing. What fork did you use exactly? https://github.com/rfay/ddev with main branch? The main branch of your fork does not have a When I use https://github.com/ddev/ddev, it offers me "Go" (because I forgot to change remove the name in line https://github.com/ddev/ddev/blob/master/.devcontainer/devcontainer.json#L4C2-L4C2). But this is correct and uses universal image. So important thing is that projects need already a valid devcontainer.json to add install-ddev feature, the guide does not state this yet. Also an odd thing is port The sample project is instead running on https://laughing-guacamole-9p595g9gph7q6-32771.app.github.dev/ But the ddev setup sh does work very different than the ones I use. |
Regarding the "get started" guide in general: Should we we provide a simple example repository? I quite liked the idea of the Or we provide the full working
Both ways would be helpful I guess ... |
Or we just provide the link to https://github.com/ddev/d9simple, just realized by now that this is already a separate repository. :-) |
Updated the d9simple repo here: https://github.com/mandrasch/d9simple/tree/feat-remove-docker-in-docker, can submit this as PR. Selected Launching this via "create new codespace" worked fine. Just need to add the db import scripts as well from https://github.com/ddev/ddev/blob/master/.devcontainer/setup_test_project.sh, if this should be used as official example:
|
Sorry, I just meant that to get the proper preview here in ddev.com-front-end I can't use a fork when doing a PR because the automated build doesn't happen then. I gave an image from my local though. |
Now... I didn't understand if you approved of this and it accomplished your goal or not. |
Hi, sorry for confusion, was a bit late yesterday in austria. 😉 😴 Review: Needs more work. I would propose we take a step back, the current guide on ddev.com can be confusing for new users since some crucial information is missing. A good first solution for me would be to copy the updated tutorial from docs to ddev.com as well: https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#github-codespaces Especially this part is missing on ddev.com: Optional side note: In my humble opinion we could shorten down this guide if we just instruct users to create a new file With using the same guide we would not have to verify two different guides. |
Let's finish the in-play work on then and we'll come back to this here. My basic thinking is that we should make it much simpler over there. It's already so much harder than gitpod, and we need to fine tune what we're asking them to do. |
The Issue
Things always changing :)
Compare to https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#github-codespaces