Use the default project_tld ddev.site
instead of "" in the global_config.yaml
#4290
Closed
1 task done
Milestone
Is there an existing issue for this?
Is your feature request related to a problem?
When #2746 has landed
project_tld: ""
was added to~/.ddev/global_config.yaml
and project files got a commented out# project_tld: ddev.site
line. As a user it isn't clear, if you only take a look at theglobal_config.yaml
, if the tld entered needs to be wrapped in quotation marks and if it is necessary to prepend a period.Describe your solution
Things could be more self explanatory by simply changing the entry in
~/.ddev/global_config.yaml
fromproject_tld: ""
toproject_tld: ddev.site
utilizing the default tld domain. that way the user directly sees the syntax for the tld active and globally applied per default. and that way the active tld would be visible at any given timen.the only caveat with my suggestion @rfay pointed out on discord is that you have to be careful in case you are changing the
global project_tld
. ddev sets the default (project_tld: DdevDefaultTLD = "ddev.site"
) inhttps://github.com/drud/ddev/blob/af1918778c56f789568951437f0a7b6ed4b15752/pkg/nodeps/values.go#L109
and then compares the constant
DdevDefaultTLD
withProjectTLD
inhttps://github.com/drud/ddev/blob/5049bdfb0a2dadf1185c63972d2e238cd2120969/pkg/ddevapp/config.go#L103-L106
Describe alternatives
No response
Additional context
I've posted the idea in a comment in an already merged and closed pull request a few days ago (#4218 (comment)). thought it would be easier to follow and track if a dedicated issue is created now instead appending the followup in an already closed pull request.
The text was updated successfully, but these errors were encountered: