Skip to content

Commit

Permalink
fix: global project_tld should default to 'ddev.site', not empty, fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
rfay committed Dec 14, 2023
1 parent 19f3e64 commit ffc606e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/ddevapp/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ func (app *DdevApp) ValidateConfig() error {
for _, hn := range app.GetHostnames() {
// If they have provided "*.<hostname>" then ignore the *. part.
hn = strings.TrimPrefix(hn, "*.")
if hn == "ddev.site" {
if hn == nodeps.DdevDefaultTLD {
return fmt.Errorf("wildcarding the full hostname or using 'ddev.site' as FQDN for the project %s is not allowed because other projects would not work in that case", app.Name)
}
if !hostRegex.MatchString(hn) {
Expand Down
1 change: 1 addition & 0 deletions pkg/globalconfig/global_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ func New() GlobalConfig {
MkcertCARoot: readCAROOT(),
ProjectList: make(map[string]*ProjectInfo),
TraefikMonitorPort: nodeps.TraefikMonitorPortDefault,
ProjectTldGlobal: nodeps.DdevDefaultTLD,
}

return cfg
Expand Down

0 comments on commit ffc606e

Please sign in to comment.