Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev share: unknown shorthand flag: 's' in -subdomain #4390

Closed
1 task done
aimfeld opened this issue Nov 18, 2022 · 2 comments
Closed
1 task done

ddev share: unknown shorthand flag: 's' in -subdomain #4390

aimfeld opened this issue Nov 18, 2022 · 2 comments

Comments

@aimfeld
Copy link

aimfeld commented Nov 18, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Run a Diagnostic and Paste Link Here

No response

Expected Behavior

ddev share --subdomain mysubdomain would work.

Actual Behavior

After upgrading ngrok to version 3.1.0, I get this error when using ddev share --subdomain mysubdomain. This worked with previous ngrok versions.

ERROR: unknown shorthand flag: 's' in -subdomain=mysubdomain

Looks like shorthand notation for subdomain is not supported by ngrok anymore. Potential fix: use --subdomain flag when passing the subdomain argument to ngrok.

Steps To Reproduce

No response

Anything else?

No response

@rfay
Copy link
Member

rfay commented Nov 21, 2022

Thanks so much, fixed in #4393

(Note: You don't need this PR to solve the problem, but instead can just use the technique in the docs, https://ddev.readthedocs.io/en/latest/users/topics/sharing/#setting-up-a-stable-ngrok-subdomain - put the ngrok args in config.yaml)

@rfay
Copy link
Member

rfay commented Nov 21, 2022

Would love to have you test, artifacts are in #4393 (comment)

@rfay rfay closed this as completed in c44ae29 Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants