ddev share --subdomain should use ngrok --subdomain, fixes #4390 #4393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
ngrok no longer accepts
-subdomain
as an arg, now--subdomain
,(Note: You don't need this PR to solve the problem, but instead can just use the technique in the docs, https://ddev.readthedocs.io/en/latest/users/topics/sharing/#setting-up-a-stable-ngrok-subdomain - put the ngrok args in config.yaml)
How this PR Solves The Problem:
Use --subdomain
Manual Testing Instructions:
With paid ngrok account,
ddev share --subdomain=xxxsomething