Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project type php shouldn't try to create settings files, should it? #5675

Closed
1 task done
rfay opened this issue Jan 3, 2024 · 1 comment
Closed
1 task done

Project type php shouldn't try to create settings files, should it? #5675

rfay opened this issue Jan 3, 2024 · 1 comment

Comments

@rfay
Copy link
Member

rfay commented Jan 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

Expand `ddev debug test` diagnostic information
[COPY-PASTE HERE THE OUTPUT OF `ddev debug test`]

Expected Behavior

PHP project type shouldn't try to create settings files or related activities

Actual Behavior

https://github.com/ddev/ddev/blob/master/pkg/ddevapp/php.go#L7-L14

I don't know how or why this got in there but it doesn't make any sense. PHP project type doesn't have settings.

Discovered in Discord, https://discordapp.com/channels/664580571770388500/1192036482068774962

Steps To Reproduce

See Discord thread.

Anything else?

No response

@rfay
Copy link
Member Author

rfay commented Jan 4, 2024

actually fixes the problem, but I'm still baffled why that code is in there.

rfay added a commit to rfay/ddev that referenced this issue Feb 2, 2024
rfay added a commit to rfay/ddev that referenced this issue Feb 4, 2024
@rfay rfay closed this as completed in baa3d75 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant