fix: when settings files not set, don't chmod, fixes #5675 #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
force-pushed
the
20240104_dont_chmod_php_settings
branch
from
3cc6e97
to
2d498a4
Compare
It only tries to create settings, and php project type never has settings
rfay
force-pushed
the
20240104_dont_chmod_php_settings
branch
from
2d498a4
to
8dafa11
Compare
rfay
changed the title
stasadev
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
phpshouldn't try to create settings files, should it? #5675Projects with no settings may fail when starting outside homedir. They shouldn't even be chmodding in that case
How This PR Solves The Issue
Manual Testing Instructions
Run
ddev start <somephpproject>in the root directory of a linux machine. It should work fine.Run
ddev start <somedrupalproject>in the root directory on linux, it should work and unwriteable settings files should be chmodded properly.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes