Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XHPROF_FLAGS_CPU #5712

Closed
1 task done
LionsAd opened this issue Jan 18, 2024 · 2 comments
Closed
1 task done

Remove XHPROF_FLAGS_CPU #5712

LionsAd opened this issue Jan 18, 2024 · 2 comments

Comments

@LionsAd
Copy link
Collaborator

LionsAd commented Jan 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

xhprof_prepend.php has:

xhprof_enable(XHPROF_FLAGS_MEMORY | XHPROF_FLAGS_CPU);

This makes xhprof unnecessary slow. (~ 50% more overhead on function calls)

Expected Behavior

xhprof_enable(XHPROF_FLAGS_MEMORY);

Actual Behavior

xhprof_enable(XHPROF_FLAGS_MEMORY | XHPROF_FLAGS_CPU);

Steps To Reproduce

ddev xhprof on

Anything else?

No response

@rfay
Copy link
Member

rfay commented Jan 19, 2024

You're the expert, if you think people can generally live without we should remove it. It was added after the original PR I think.

@rfay
Copy link
Member

rfay commented Jan 19, 2024

(A PR would move this along quite fast :) )

LionsAd added a commit to LionsAd/ddev that referenced this issue Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants