fix: make xhprof faster, fixes #5712 #5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionsAd
changed the title
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
xhprof_prepend.php uses:
This makes xhprof unnecessary slow. (~ 50% more overhead on function calls)
How This PR Solves The Issue
It uses just:
Manual Testing Instructions
Ensure that xhprof output does no longer show the CPU columns and generally has less function call overhead.
Automated Testing Overview
Tests should not be affected, because they only test the existence of a run and not the run itself.
Related Issue Link(s)
#5712
Release/Deployment Notes
None