New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content tests in TestDdevFullSiteSetup, fixes #677 #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20181004_check_cms_content
branch
2 times, most recently
from
October 6, 2018 23:34
e7e7344
to
4070753
Compare
andrewfrench
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and adds a lot of confidence in behavior that we didn't have before. Will the WordPress-in-a-directory stuff be added to this PR?
rfay
force-pushed
the
20181004_check_cms_content
branch
from
October 8, 2018 18:55
46f2ab6
to
9bf2d91
Compare
…gs in unstable state
rfay
force-pushed
the
20181004_check_cms_content
branch
from
October 8, 2018 20:37
9bf2d91
to
8c298aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
We have long had a set of tests that carefully does a
ddev start
andddev import-db
and `ddev import-files on several CMSs... but never checks to see if each CMS responds appropriately. OP#677.How this PR Solves The Problem:
Since this has been neglected for some time there are a few things that will have to be done for basic functionality, and a few that should probably be done just as an update mechanism.
docker inspect
what the actual healthcheck issue is. We now check for /var/www/html being "sane" and for mysql being accessible.Additional changes:
Manual Testing Instructions:
Mostly this will be the automated test, but there are some features to manually test:
docker inspect
to view the health status of a starting webserver. It shows the actual status of 3 different things.Automated Testing Overview:
Related Issue Link(s):
OP #677
Release/Deployment notes: