Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an easy way to populate environment variables in the web container #757

Closed
rfay opened this issue Mar 27, 2018 · 6 comments
Closed

Comments

@rfay
Copy link
Member

rfay commented Mar 27, 2018

What happened (or feature request):

TYPO3 users often request a way to set environment variables in the web container.

This is not hard to do with docker-compose.yaml, but we're really on course to take complete control of that file and recreate it on every start.

So we should provide a way to do it in config.yaml.

What you expected to happen:

How to reproduce this:

Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.

Anything else do we need to know:

Related source links or issues:

Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

@kaystrobach
Copy link

suggestion:

beside the normal nginx-site.conf there should be an nginx-env-vars.conf

This file should have the same structure as /etc/nginx/fastcgi_params and could make it easy to add env vars ...

@rfay
Copy link
Member Author

rfay commented Mar 28, 2018

Nice work on this in #758 - it probably can't go in there because it's not general enough (TYPO3-oriented) but it certainly explains one way to do it.

@kaystrobach
Copy link

not typo3 specific ... the composer package is just env vars ... and uses composer plugin architecture

@rfay
Copy link
Member Author

rfay commented Apr 4, 2018

When reworking our setup of docker-compose.yml in #762 we can move away from using environment variables at all, and that will allow us to build a docker-compose.yml that populates the environment section more effectively.

@rfay
Copy link
Member Author

rfay commented Apr 19, 2018

Don't forget #758 when working on this, it's an important specific approach.

@rfay
Copy link
Member Author

rfay commented Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants