Document adding extra env variables, fixes #757, also #758 (docs only) #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerjfco
approved these changes
May 1, 2018
| @@ -13,6 +13,24 @@ A collection of vetted service configurations is available in the [Additional Se | |||
|
|
|||
| If you need to create a service configuration for your project, see [Defining an additional service with Docker Compose](custom-compose-files.md) | |||
|
|
|||
| ## Providing custom environment variables to a container | |||
|
|
|||
| Each project can have an unlimited number of .ddev/docker-compose.*.yaml files, so it's easy to maintain custom environment variables in a .ddev/docker-compose.environment.yaml file (the exact name doesn't matter, if it just matches docker-compose*.y*ml). | |||
There was a problem hiding this comment.
nit, the last mentioned file name format should be docker-compose..yml. the first mentioned one also uses .yaml vs .y*ml. i wonder if we should just document one of the two yaml extensions rather than using the *. not sure how much confusion that could be for some people
|
|
||
| Each project can have an unlimited number of .ddev/docker-compose.*.yaml files, so it's easy to maintain custom environment variables in a .ddev/docker-compose.environment.yaml file (the exact name doesn't matter, if it just matches docker-compose*.y*ml). | ||
|
|
||
| For example, |
There was a problem hiding this comment.
it might help to provide an example file name here for extra clarity. I think it could also be useful to spell out that this example would add env vars to both the web and db containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #757 points out that especially TYPO3 users need to set environment variables in the container. It's actually quite easy to do (without editing the main docker-compose.yaml). This just tells how to do it.
Thanks @kaystrobach - Hope you can review this.
How this PR Solves The Problem:
Adds docs with simple technique.