Increase timeout on ddev-router and ddev-webserver for slower machines, fixes #2120 #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20200324_longer_router_timeout
branch
from
678d530
to
48c093e
Compare
|
Artifacts to test this are at https://circleci.com/gh/drud/ddev/23558#artifacts/containers/0 - you have to drill down into the artifacts |
rfay
force-pushed
the
20200324_longer_router_timeout
branch
from
48c093e
to
2fa3834
Compare
rfay
force-pushed
the
20200324_longer_router_timeout
branch
from
2fa3834
to
5faa2c5
Compare
rfay
force-pushed
the
20200324_longer_router_timeout
branch
from
5faa2c5
to
1558273
Compare
rfay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#2120 reports that on a slower machine (2011 MBP) and probably a larger project,
ddev startcan report a timeout... butddev listimmediately shows it being OK.We've also seen this in a few situations with ddev-webserver
How this PR Solves The Problem:
Loosen the timeout for ddev-router and ddev-webserver
Manual Testing Instructions:
Currently I don't have a way to test this, but will ask @rpkoller to test.
ddev startshould succeed predictably on slower machines)ddev startshould take about the same amount of time as previously on recent machines.Automated Testing Overview:
I think existing tests will test for regressions just fine. Many, many ddev starts are done.
Related Issue Link(s):
OP #2120
Release/Deployment notes: