Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step-debugging.md #2499

Merged
merged 4 commits into from Sep 16, 2020
Merged

Update step-debugging.md #2499

merged 4 commits into from Sep 16, 2020

Conversation

amitaibu
Copy link
Contributor

@amitaibu amitaibu commented Sep 9, 2020

The Problem/Issue/Bug:

Couldn't start xdebug based on current docs

How this PR Solves The Problem:

Adding some necessary steps and notes

Some xdebug improvements
@amitaibu amitaibu marked this pull request as ready for review September 9, 2020 17:30
@amitaibu
Copy link
Contributor Author

amitaibu commented Sep 9, 2020

I assume Travis is failing on something not related to this docs PR

@rfay
Copy link
Member

rfay commented Sep 9, 2020

markdownlint failed,

docs/users/step-debugging.md:46:1 MD029/ol-prefix Ordered list item prefix [Expected: 2; Actual: 1; Style: 1/2/3]
Makefile:134: recipe for target 'markdownlint' failed
make: *** [markdownlint] Error 1

docs/users/step-debugging.md Outdated Show resolved Hide resolved
@amitaibu
Copy link
Contributor Author

I've added also a reference to ufw - to give a sense (and possibly the solution) for cases where not request arrives PHPStorm.

@rfay rfay merged commit 7c70ab5 into ddev:master Sep 16, 2020
@rfay
Copy link
Member

rfay commented Sep 16, 2020

Thanks for this @amitaibu !

@amitaibu amitaibu deleted the patch-1 branch September 17, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants