Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pantheon pull to use terminus backup:get #2957

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

rfay
Copy link
Member

@rfay rfay commented Apr 21, 2021

The Problem/Issue/Bug:

The previous (drush rsync) technique for pulling a backup from Pantheon was just way too tedious, and could even fail due to connection timeouts

How this PR Solves The Problem:

Use terminus backup:get. command and require that a backup already exists.

Manual Testing Instructions:

Use the "pull" sections of the new strategy with your site and see if it works.

@rfay rfay merged commit e41c2f0 into ddev:master Apr 23, 2021
@rfay rfay deleted the 20210421_terminus_downloads_from_backup branch April 23, 2021 17:30
@amitaibu
Copy link
Contributor

@rfay Worked great! (I only wish there was a progress report in terminus for the files get -which in my case took quite a long time)

Two suggestions:

  1. Since db_push_command and files_push_command are dangerous, how about commenting them out? Let's force user for one more step, before they accidentally destroy their env.
  2. Since files_push_command is now the only command using drush directly, I think we can remove the terminus aliases 2>/dev/null from the auth_command and move it to be under files_push_command. Like that we'd save a bit of time on each authentication.

@rfay
Copy link
Member Author

rfay commented Apr 24, 2021

I agree with you on both.

It was actually DDEV (the company) that kept pushing for "push" for integration with DDEV-Live, and I probably wouldn't have done it anyway.

The time for terminus aliases is irrelevant compared to the time for pull though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants