Set laravel PHP default to 8.1, fixes #4651

[rfay]

The Issue

Laravel 10 requires PHP 8.1:

• Laravel 10 requires PHP 8.1 #4651

How This PR Solves The Issue

• Change default version in code
• For now, change docs to show explicit --php-version

Manual Testing Instructions

• Test with laravel
• Test quickstart

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

[tyler36]

Looks good to me.

[rfay]

Laravel test in TestDdevFullSiteSetup is using a canned laravel code setup, has to be updated,
https://github.com/drud/ddev/blob/12a9d92d7ed3ebc24afa04c038f3ff90ca43698a/pkg/ddevapp/ddevapp_test.go#L180-L195

[tyler36]

That appears to be Laravel Lumen:

"php": "^7.2.5",
"laravel/lumen-framework": "^7.0"

Currently, Laravel Lumen is at the follow, so still lower requirements than Laravel 10:

"php": "^8.0",
"laravel/lumen-framework": "^9.0"

[rfay]

The preference is to use the actual upstream code, but I think it requires composer install, which typically takes too long in tests, but we can make a new tarball of Laravel 10 with composer dependencies I guess...

[rfay]

@tyler36 following the quickstart I get Laravel v9.52.0, https://ddev.readthedocs.io/en/latest/users/quickstart/#laravel

So I'm on the wrong track trying to create a new tarball for code etc. If laravel 10 has been released... is it not in composer?

[tyler36]

Just ran through updated quickstart again and I'm getting 10.0.2

$ mkdir my-laravel-app
$ cd my-laravel-app
$ ddev config --project-type=laravel --docroot=public --create-docroot --php-version=8.1
$ ddev composer create --prefer-dist --no-install --no-scripts laravel/laravel -y
...
Creating a "laravel/laravel" project at "/tmp/YQMaGP"
Info from https://repo.packagist.org: #StandWithUkraine
Installing laravel/laravel (v10.0.2)
  - Downloading laravel/laravel (v10.0.2)
  - Installing laravel/laravel (v10.0.2): Extracting archive

Since that's running in a new container instance, I assume theres no composer caching issue right?

[rfay]

Oh, here's the interesting thing. It's fancy:

Cannot use laravel/laravel's latest version v10.0.3 as it requires php ^8.1 which is not satisfied by your platform.

So it ends up switching to laravel 9.5!

[tyler36]

Just retested this and everything appears fine.

$ ddev -v
ddev version v1.21.6-40-g221bdecb

This version results in Laravel v10.6.2 (PHP v8.1.16).

As suggested above, I think we need to add -y

- ddev composer create --prefer-dist --no-install --no-scripts laravel/laravel
+ ddev composer create --prefer-dist --no-install --no-scripts laravel/laravel -y

Without this, the installation pauses for confirmation:

$ ddev composer create --prefer-dist --no-install --no-scripts laravel/laravel
...
Warning: MOST EXISTING CONTENT in the composer root (/home/user13/temp/my-laravel-app) will be deleted by the composer create-project operation. Only .ddev, .git and .tarballs will be preserved.
Would you like to continue? [Y/n] (yes):

By including -y, I can copy/paste the entire quickstart block into my terminal and 47s later, the website opens.

[mattstein]

Looks good, sorry for the long wait from me!