Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHP 8.1 by default, fixes #4652 #4834

Merged
merged 9 commits into from
May 3, 2023
Merged

Use PHP 8.1 by default, fixes #4652 #4834

merged 9 commits into from
May 3, 2023

Conversation

davereid
Copy link
Contributor

@davereid davereid commented Apr 19, 2023 •
edited

The Issue

How This PR Solves The Issue

Changes defaults to use PHP 8.1 for new sites or sites that do not have configuration set for php_version.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Fixes #4652

Release/Deployment Notes

@davereid davereid requested a review from a team as a code owner April 19, 2023 00:25
@davereid davereid marked this pull request as draft April 19, 2023 00:25
@davereid davereid changed the title Update Dockerfile Use PHP 8.1 by default Apr 19, 2023
@rfay rfay changed the title Use PHP 8.1 by default Use PHP 8.1 by default, fixes #4652 Apr 19, 2023
rfay
rfay requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

This does a lot of it, but you'll find more places.

  • The container tests, for example, don't know about the golang defaults.
  • versionconstants.go has to be changed to point to a pushed image. I can do that after we push the image.

@rfay rfay marked this pull request as ready for review May 3, 2023 01:16
@rfay rfay requested a review from a team as a code owner May 3, 2023 01:16
rfay
rfay approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, made some changes to docs, pushed images, etc.

@rfay rfay merged commit 10c6ade into ddev:master May 3, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change PHP Default version to 8.1 in v1.22.0
2 participants
@davereid @rfay