Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Adjusted the FAQ 'communication between projects faq' #4757

Merged
merged 6 commits into from
Mar 17, 2023
Merged

[docs] Adjusted the FAQ 'communication between projects faq' #4757

merged 6 commits into from
Mar 17, 2023

Conversation

jeroenpeters1986
Copy link
Contributor

@jeroenpeters1986 jeroenpeters1986 commented Mar 16, 2023 •
edited by gitpod-io bot
Loading

The Issue

  • It wasn't really clear where to put the docker-compose.communicate.yaml file directly
  • Fixed the syntax of the example, it had wrong indentation

How This PR Solves The Issue

  • Added a bit more context
  • Fixed the indentation

Manual Testing Instructions

  • None, as this is for the docs

Automated Testing Overview

  • None, as this is for the docs

Related Issue Link(s)

  • None, I fixed this as I saw it

Release/Deployment Notes

  • None, as this is for the docs

@jeroenpeters1986
Update faq.md
36aca5b 
Clarified the bit on communication between two projects a bit more, and fixed the syntax
@jeroenpeters1986
[docs] Adjusted communication between projects
2da7952 
Clarified faq item on communication between projects + fixed syntax
rfay
rfay approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to make the FAQ better. Just made one minor suggestion, that you can commit by clicking the button.

docs/content/users/usage/faq.md Outdated Show resolved Hide resolved
@rfay rfay requested a review from mattstein March 16, 2023 12:42
mattstein
mattstein suggested changes Mar 16, 2023
View reviewed changes
Copy link
Sponsor Collaborator

@mattstein mattstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nitpicks from me. Thanks for the PR!

docs/content/users/usage/faq.md Outdated Show resolved Hide resolved
docs/content/users/usage/faq.md Outdated Show resolved Hide resolved
jeroenpeters1986 and others added 3 commits March 16, 2023 14:27
@jeroenpeters1986 @rfay
Update docs/content/users/usage/faq.md
769b45f 
Co-authored-by: Randy Fay <randy@randyfay.com>
@jeroenpeters1986 @mattstein
Update docs/content/users/usage/faq.md
7054aef 
Co-authored-by: Matt Stein <m@ttste.in>
@jeroenpeters1986 @mattstein
Update docs/content/users/usage/faq.md
3f908e6 
Co-authored-by: Matt Stein <m@ttste.in>
@jeroenpeters1986
Copy link
Contributor Author

@rfay @mattstein Thanks for checking my PR so fast guys, happy to contribute as I'm a DDEV fan :-)

rfay
rfay approved these changes Mar 16, 2023
View reviewed changes
docs/content/users/usage/faq.md Show resolved Hide resolved
@rfay
Copy link
Member

rfay commented Mar 16, 2023

docs check seems to be broken right now only because xdebug.org is down.

@rfay rfay merged commit c3f360e into ddev:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstein mattstein mattstein requested changes

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeroenpeters1986 @rfay @mattstein