fix: remove test@example.org from BCC in mailpit sendmail_path, fixes #5381

[joelpittet]

The Issue

The test@example.org is added to all email's BCC in MailPit through PHP's sendmail_path config.

• Email captured by mailpit shows a BCC to test@example.org #5381

How This PR Solves The Issue

Remove unneeded args from sendmail_path

Manual Testing Instructions

Send email from PHP inside the web container and go to mailpit to look at BCC line.

Automated Testing Overview

[joelpittet]

I think the title does conform to the standard

[rfay]

It's pretty picky. Not sure why it has to be that picky. fixed the capitalization.

[rfay]

I pushed the needed docker images and added a commit to refer to them. I'm not sure why github actions hasn't provided the normal link to the artifacts for you to test. Maybe it will show up before long.

[rfay]

Artifacts for testing are at https://github.com/ddev/ddev/actions/runs/6319112543

[tyler36]

Laravel 10

Issue not present with Laravel 10.4.1 & DDEV 1.22.3

• Generic mail
  Mail::raw('Hello World!', function($msg) {$msg->to('example@example.com')->subject('Test Email'); });

• Specify 'secret@example.com as BCC
  Mail::raw('Hello World!', function($msg) {$msg->to('example@example.com')->bcc('secret@example.com')->subject('Test Email'); });

Drupal 10

Confirm issue on Drupal 10 with DDEV 1.22.3

• Use UI to send password reset email to admin@example.com
  

However, DDEV 1.22.3-13-gc2dd4f439 appears to fix the issue.

• Use UI to send password reset email to admin@example.com
  

[rfay]

@tyler36 I think Laravel doesn't use the php config and connects directly via SMTP, which would be why you wouldn't see this problem on Laravel. Things like Symfony Mailer also use directly configured SMTP so wouldn't be affected by #5381

[rfay]

This looks right to me, but would love to have some other people give it a go and review like @tyler36 did.

[tyler36]

I think Laravel doesn't use the php config

Yes, thats right. Just confirming no issue with Laravel.

[tyler36]

Confirming Laravel 10.4.1 & DDEV 1.22.3-13-gc2dd4f439 works exactly the same too; so nothing broke. 😄

[rfay]

I think this may have been a mistake, or we don't know yet how far we have to go. Shopware 6 croaks installing demo data with this:

Internal Server Error
Unsupported sendmail command flags "/usr/local/bin/mailpit sendmail --smtp-addr 127.0.0.1:1025"; must be one of "-bs" or "-t" but can include additional flags.

[joelpittet]

@rfay oh sorry maybe I over stepped with the -t removal :( Would you like me to submit a new PR to add it back?

[rfay]

It was reasonable, and @Axilent approved in the issue.

@Axilent, would you mind commenting on #5383 (comment) ? Is that just poor usage by Shopware6?

@joelpittet I'd love it if you'd follow up with an option depending on the discussion. If you know anything about Shopware 6, that much better!

[joelpittet]

I know nothing of Shopware6, but it's trying to parse the command for valid flags. I tried to get symfony to stop doing that one time... might be related (was rejected).
https://www.drupal.org/project/swiftmailer/issues/3174215
symfony/symfony#47020

[rfay]

I'll bet it is the same thing. This is a symfony build.

[joelpittet]

@rfay Separate PR adding back the -t flag?

[rfay]

Yeah, please do. Thanks so much.