fix: partial revert of #5383 add -t flag back to mailpit sendmail command #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelpittet
changed the title
joelpittet
changed the title
|
Requires rebuild/push/tag of ddev-php-base and ddev-webserver, will get to that soon. |
github-actions
bot
added
the
dependencies
|
Pushed the required images. |
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Adds the
-tflag back to sendmail command so that symfony mailer validation is appeased.Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
fix: remove test@example.org from BCC in mailpit sendmail_path, fixes #5381 #5383
https://www.drupal.org/project/swiftmailer/issues/3174215
Update SendmailTransport.php symfony/symfony#47020