New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ddev pull upsun
provider integration, fixes #5446
#5529
Conversation
Download the artifacts for this pull request:
See Testing a PR |
ddev-windows-mutagen isn't supposed to run on PRs... I guess it's because you did this PR on ddev org. And of course it's irrelevant to this PR. But TestUpsunPull/Push worked, yay, https://github.com/ddev/ddev/actions/runs/6829336445/job/18575278444?pr=5529 |
ddev pull upsun
provider integration, fixes #5446
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks!
In docs, I think this needs a mention in the top-level providers markdown file, which is hard to find, that's a different problem.
I also think we need a blog post about providers in general and the two new ones specifically.
Right now, trying to manually test with ddev push upsun
I'm stuck on
Uploading database...
Wrote database dump from project 'upsun-d10' database 'db' to file /Users/rfay/workspace/upsun-d10/.ddev/.downloads/db.sql.gz in gzip format.
The server responded:
Hello Randy Fay (UUID: 949f3e03-0c56-479e-8131-3a0eecc6d412), you successfully authenticated, but could not connect to service o2wd4lih6xwpc-main-bvxea6i--ddev-d10 (reason: service doesn't exist or you do not have access to it)
Multiple databases does not yet work, because To configure multiple databases in upsun you need to have them configured in the .upsun/config.yaml:
But
I guess the difference is the key, |
I guess the logic in ddev/pkg/ddevapp/dotddev_assets/providers/platform.yaml Lines 54 to 57 in a0e022e
It's worth a little effort to fix it, or we can just say "only one db for now" |
I will look into it tomorrow, and if I can't figure it out quickly, we can proceed with "only one db for now". |
So far I haven't found a good way to list the databases provided. Have questions going in slack. You don't need to fiddle with it until they reply. thanks! Also added you to project with two databases, https://console.upsun.com/ddev/47kohks3azo5c |
aa64d81
to
6a87b53
Compare
Removed relationships (they do not work and are not needed at the moment) and rebased. |
Co-authored-by: Randy Fay <randy@randyfay.com>
6a87b53
to
3307af2
Compare
Rebased, but didn't re-push. This will need to be re-pushed before it's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. I manually tested pull with rfay-d10, and branched a new testpush
environment and did ddev push upsun --environment=UPSUN_PROJECT=testpush
and it worked out fine.
I updated the ddev-webserver image. |
The Issue
ddev pull upsun
support #5446How This PR Solves The Issue
Adds integration for Upsun.
Manual Testing Instructions
Docs are here https://ddev--5529.org.readthedocs.build/en/5529/users/providers/upsun/
Try
ddev pull upsun
in Upsun projectTry
ddev push upsun
Automated Testing Overview
TestUpsunPull
andTestUpsunPush
.Related Issue Link(s)
Release/Deployment Notes