Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: install only binary from Upsun, for #5529 #5564

Merged
merged 1 commit into from Nov 24, 2023
Merged

build: install only binary from Upsun, for #5529 #5564

merged 1 commit into from Nov 24, 2023

Conversation

stasadev
Copy link
Member

The Issue

ddev exec sudo apt update | grep upsun
Get:7 https://dl.cloudsmith.io/public/platformsh/upsun-cli/deb/debian bullseye InRelease [5079 B]

I think we don't really want the Upsun repo to be pulled up on sudo apt update.

  1. It's not needed here, because not everyone uses it.
  2. This can lead to unpredictable behavior if someone has a post-start hook for sudo apt update && sudo apt upgrade, a new untested version of Upsun can be installed, and then who knows how ddev pull upsun will behave.

How This PR Solves The Issue

Installs only upsun binary, without any extras.

Manual Testing Instructions

ddev exec upsun version
ddev pull upsun -y --environment UPSUN_PROJECT=xxx,UPSUN_ENVIRONMENT=yyy --skip-files

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner November 23, 2023 17:42
@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance labels Nov 23, 2023
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

See Testing a PR

@rfay rfay merged commit 6229c05 into ddev:master Nov 24, 2023
22 of 23 checks passed
@stasadev stasadev deleted the 20231123_stasadev_upsun branch November 24, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stasadev @rfay