New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: order host, port, driver the same both places in Drupal 10 settings file #5570
Conversation
Download the artifacts for this pull request:
See Testing a PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it makes a difference, but fine with me :)
I assume that the d8 and d9 have the same difference?
It's a tiny change, but now they are aligned in their order :) |
Order is good, right? |
Yes, indeed :) The reason I noticed it, was because I wanted to run MySQLTuner, and needed the host/port info. It took me a while to finally just try replacing
|
and https://ddev.readthedocs.io/en/latest/users/usage/database-management/ |
Thanks for the tips, reading the docs closer, this would have gotten me on track:
|
The Issue
It is not a big problem, but the order of host, port, driver is switched, causing a slight "hmm" when you scan the values.
How This PR Solves The Issue
Makes the order identical to the one in the default settings.php file:
https://github.com/drupal/drupal/blob/10.1.x/sites/default/default.settings.php#L80-L85
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes