fix: remove CRAFT_WEB_URL, fixes #5665 #5668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The
CRAFT_WEB_URL
env variable is not necessary for a Craft project, and prevents multi-site features from working.How This PR Solves The Issue
Does not manage
CRAFT_WEB_URL
.It also removes the comment about backward compatibility, as it isn't quite true. While
PRIMARY_SITE_URL
isn't an "official" var that Craft uses, it is a de-facto standard, as Craft's installer script will attempt to set it, and it is helpful to have the primary site set to reference in your config.Manual Testing Instructions
Start a craftcms ddev project:
Ensure
CRAFT_WEB_URL
was not written to.env
(command should have no output):Automated Testing Overview
Related Issue Link(s)
Fixes #5665
Release/Deployment Notes