Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change database default to mariadb:10.11, fixes #5797 #5836

Merged
merged 15 commits into from Feb 23, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 13, 2024

The Issue

How This PR Solves The Issue

Changes the default. Tries to catch up on some test items that seem to have been neglected.

Manual Testing Instructions

In an empty directory, ddev config --auto && ddev start. ddev describe should show it running mariadb:10.11

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link

github-actions bot commented Feb 13, 2024

@rfay rfay force-pushed the 20240213_mariadb_1011_default branch from 34add78 to 612b830 Compare February 14, 2024 16:40
Copy link
Member Author

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has implications for 'latest' docs, but they're not too big. It says 10.11 is default.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 15, 2024
@rfay
Copy link
Member Author

rfay commented Feb 15, 2024

It's worth looking a a couple of things here:

  • Why wasn't mariadb 10.11 previously being tested when snapshots and export-db were tested (export-db wasn't testing bzip2 on mariadb 10.11 for sure)?
  • Are there build complaints in several of the image builds? (Could be spun off into another issue). I know I saw one that has the complaint about where the keys are kept.

@rfay rfay force-pushed the 20240213_mariadb_1011_default branch from e2b6081 to e07412c Compare February 15, 2024 22:19
@rfay
Copy link
Member Author

rfay commented Feb 17, 2024

mariadb:10.4 failure seems to happen only on certain macOS systems.

I'm able to recreate this, mariadb:10.4 only, on arm64. Maybe it's just arm64 that's the problem. Suspecting bad image push.

2024-02-16 17:40:46 0 [Note] InnoDB: Cannot open '/var/lib/mysql/ib_buffer_pool' for reading: No such file or directory
2024-02-16 17:40:46 0 [Note] Plugin 'FEEDBACK' is disabled.
2024-02-16 17:40:46 0 [ERROR] Could not open mysql.plugin table. Some plugins may be not loaded
2024-02-16 17:40:46 0 [ERROR] Failed to initialize plugins.
2024-02-16 17:40:46 0 [ERROR] Aborting

Stack Overflow says this may be out-of-memory, but I doubt it. Another almost certainly unrelated: https://stackoverflow.com/questions/34198735/could-not-open-mysql-plugin-table-some-plugins-may-be-not-loaded

@rfay
Copy link
Member Author

rfay commented Feb 17, 2024

I re-pushed from arm64 machine and it solved this.

make PUSH=true DOCKER_ARGS=--no-cache VERSION=20240213_mariadb_1011_default mariadb_10.4

I will look at the original push (done via github) to see if there are any clues there.

@rfay rfay force-pushed the 20240213_mariadb_1011_default branch from 5999cbb to c6bf7d4 Compare February 17, 2024 17:37
@rfay
Copy link
Member Author

rfay commented Feb 17, 2024

The last docker build here was done in https://github.com/rfay/ddev/actions/runs/7909096636/job/21589704201

It failed mariadb:10.8 and 10.11, didn't understand why, and pushed those from arm64 mac.

I don't see anything at all interesting reviewing the 10.4 build there.

I'll bet this would have failed the CircleCI arm64 build if we had it still enabled for PRs

@rfay rfay marked this pull request as ready for review February 17, 2024 21:17
@rfay rfay requested review from a team as code owners February 17, 2024 21:17
@rfay
Copy link
Member Author

rfay commented Feb 17, 2024

Why wasn't mariadb 10.11 previously being tested when snapshots and export-db were tested (export-db wasn't testing bzip2 on mariadb 10.11 for sure)?

TestDdevExportDB currently only tests the current default MariaDB version, no others.
TestCmdExportDB also tests only with MariaDB and only with current default
TestDdevAllDatabases test all the right permutations except Postgres:9, which can't properly be done. But it doesn't do bzip2 exports or imports.

@rfay
Copy link
Member Author

rfay commented Feb 17, 2024

Are there build complaints in several of the image builds?

I see this in images based on Ubuntu 22.04: "Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).", but they're in the context of us using apt-key to remove expired keys:

RUN for item in "75DD C3C4 A499 F1A1 8CB5 F3C8 CBF8 D6FD 518E 17E1" "126C 0D24 BD8A 2942 CC7D F8AC 7638 D044 2B90 D010" "D211 6914 1CEC D440 F2EB 8DDA 9D6D 8F6B C857 C906" "A1BD 8E9D 78F7 FE5C 3E65 D8AF 8B48 AD62 4692 5553" "ED6D 6527 1AAC F0FF 15D1 2303 6FB2 A1C2 65FF B764"; do apt-key remove "${item}" || true; done;

I don't think we have to worry about that problem, although we do have to figure out how to stop using apt-key for testing expiration in general, but that should be captured in

@rfay
Copy link
Member Author

rfay commented Feb 17, 2024

The problem pushing images with Ubuntu 22.04-derived dbimages (mariadb:10.8 + mariadb:10.11) is a SEGV on libc-bin (https://github.com/rfay/ddev/actions/runs/7944511561/job/21690113653#step:7:1533)

#16 71.57 Processing triggers for libc-bin (2.35-0ubuntu3.6) ...
#16 71.74 Segmentation fault (core dumped)
#16 71.87 Segmentation fault (core dumped)
#16 71.88 dpkg: error processing package libc-bin (--configure):
#16 71.88  installed libc-bin package post-installation script subprocess returned error exit status 139
#16 71.89 Errors were encountered while processing:
#16 71.89  libc-bin
#16 71.98 E: Sub-process /usr/bin/dpkg returned an error code (1)
#16 ERROR: process "/bin/bash -c apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get install -y -o Dpkg::Options::=\"--force-confold\" bzip2 curl gnupg2 less lsb-release pv tzdata vim wget" did not complete successfully: exit code: 100

@rfay
Copy link
Member Author

rfay commented Feb 17, 2024

f3d0804 seems to solve the push problem

@rfay rfay requested a review from stasadev February 19, 2024 19:36
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the difference is, but the two files are named incorrectly.

@rfay rfay force-pushed the 20240213_mariadb_1011_default branch from 52d62bd to cda677c Compare February 19, 2024 21:11
@rfay rfay force-pushed the 20240213_mariadb_1011_default branch from cda677c to a56c87f Compare February 21, 2024 21:38
@rfay rfay merged commit 20a58d4 into ddev:master Feb 23, 2024
22 checks passed
@rfay rfay deleted the 20240213_mariadb_1011_default branch February 23, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants