New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change database default to mariadb:10.11, fixes #5797 #5836
Conversation
Download the artifacts for this pull request:
See Testing a PR |
34add78
to
612b830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has implications for 'latest' docs, but they're not too big. It says 10.11 is default.
It's worth looking a a couple of things here:
|
e2b6081
to
e07412c
Compare
mariadb:10.4 failure seems to happen only on certain macOS systems. I'm able to recreate this, mariadb:10.4 only, on arm64. Maybe it's just arm64 that's the problem. Suspecting bad image push.
Stack Overflow says this may be out-of-memory, but I doubt it. Another almost certainly unrelated: https://stackoverflow.com/questions/34198735/could-not-open-mysql-plugin-table-some-plugins-may-be-not-loaded |
I re-pushed from arm64 machine and it solved this.
I will look at the original push (done via github) to see if there are any clues there. |
5999cbb
to
c6bf7d4
Compare
The last docker build here was done in https://github.com/rfay/ddev/actions/runs/7909096636/job/21589704201 It failed mariadb:10.8 and 10.11, didn't understand why, and pushed those from arm64 mac. I don't see anything at all interesting reviewing the 10.4 build there. I'll bet this would have failed the CircleCI arm64 build if we had it still enabled for PRs |
TestDdevExportDB currently only tests the current default MariaDB version, no others. |
I see this in images based on Ubuntu 22.04: "Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).", but they're in the context of us using
I don't think we have to worry about that problem, although we do have to figure out how to stop using apt-key for testing expiration in general, but that should be captured in |
The problem pushing images with Ubuntu 22.04-derived dbimages (mariadb:10.8 + mariadb:10.11) is a SEGV on libc-bin (https://github.com/rfay/ddev/actions/runs/7944511561/job/21690113653#step:7:1533)
|
f3d0804 seems to solve the push problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the difference is, but the two files are named incorrectly.
cmd/ddev/cmd/testdata/TestConfigDatabaseVersion/config.yaml.imagespec.10.7
Outdated
Show resolved
Hide resolved
cmd/ddev/cmd/testdata/TestConfigDatabaseVersion/config.yaml.imagespec.10.8
Outdated
Show resolved
Hide resolved
52d62bd
to
cda677c
Compare
cda677c
to
a56c87f
Compare
The Issue
How This PR Solves The Issue
Changes the default. Tries to catch up on some test items that seem to have been neglected.
Manual Testing Instructions
In an empty directory,
ddev config --auto && ddev start
.ddev describe
should show it running mariadb:10.11Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes