Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve database type and version visibility #5884

Merged
merged 14 commits into from Feb 27, 2024
Merged

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Feb 22, 2024

The Issue

While following #5468 (comment) , it's not easy to scan the docs for supported databases.

How This PR Solves The Issue

A tweak to layout that makes it easier to see database types and versions.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

#5468 (comment)

Release/Deployment Notes

@tyler36
Copy link
Collaborator Author

tyler36 commented Feb 22, 2024

Should we include addons that expand database support?
For example:

  • ddev/ddev-mongo

@tyler36 tyler36 mentioned this pull request Feb 22, 2024
1 task
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this

docs/content/users/extend/database-types.md Outdated Show resolved Hide resolved
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need more work after

@tyler36
Copy link
Collaborator Author

tyler36 commented Feb 22, 2024

Is it OK to add sqlsrv to dictionary? Suprised it not there already.

@rfay
Copy link
Member

rfay commented Feb 22, 2024

Adding references to add-ons is fine, thanks.

@tyler36
Copy link
Collaborator Author

tyler36 commented Feb 22, 2024

Added the mongo & sqlsrv addons.
Also included a reference to --list --all to future-proof for community-supported addons.

@rfay
Copy link
Member

rfay commented Feb 25, 2024

Please rebase, thanks! Please improve the title to say what is being updated.

@tyler36 tyler36 changed the title docs: Update database-types docs: improve database type and version visibility Feb 26, 2024
@tyler36 tyler36 marked this pull request as ready for review February 26, 2024 00:49
@tyler36 tyler36 requested review from a team as code owners February 26, 2024 00:49
@tyler36 tyler36 requested a review from rfay February 26, 2024 00:49
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.spellcheckwordlist.txt Outdated Show resolved Hide resolved
docs/content/users/extend/database-types.md Outdated Show resolved Hide resolved
docs/content/users/extend/database-types.md Outdated Show resolved Hide resolved
docs/content/users/extend/database-types.md Outdated Show resolved Hide resolved
tyler36 and others added 4 commits February 27, 2024 08:45
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
@tyler36 tyler36 requested a review from rfay February 26, 2024 23:49
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, minor comments to commit (mariadb default has changed). Thanks!

docs/content/users/extend/database-types.md Outdated Show resolved Hide resolved
docs/content/users/extend/database-types.md Outdated Show resolved Hide resolved
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this. Sometimes a little thing takes way too much work, but thanks for keeping at it. This should get in tomorrow or very soon.

@rfay rfay merged commit 499b164 into ddev:master Feb 27, 2024
10 checks passed
@tyler36 tyler36 deleted the patch-8 branch March 4, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants