-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use $XDG_CONFIG_HOME in Gitpod for v1.23.2 release, for #6228 [skip ci] #6315
Conversation
bd174c0
to
25c5996
Compare
@shaal, please take a look, this is something you will also need to do with DrupalPod. |
Maybe this actually does it for Drupalpod? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
As far as I understand, it doesn't use Pulling it. |
Yay! Oh, I didn't realize you were doing this?
|
Yeah, I thought it would be nice to have a link there to avoid problems if users override something in the global config directory and use the DDEV itself still uses |
If it's too confusing, we can remove the symlink. |
I don't think anybody will ever know the difference. |
Actually, it will probably help me, because I have ~/.ddev in my fingers. Probably we should have suggested that approach to @danepowell in the first place :) |
The Issue
~/.ddev
in Codespaces #6228How This PR Solves The Issue
Sets
XDG_CONFIG_HOME=/workspace/.config
inside the Gitpod container.DDEV global configuration will be stored in a non-volatile location:
${XDG_CONFIG_HOME}/ddev
I added a symlink from
~/.ddev
to${XDG_CONFIG_HOME}/ddev
, so it won't break a custom user script (e.g. in hooks) that uses the~/.ddev
location.Manual Testing Instructions
Click Open in Gitpod, change some global config setting, e.g.:
Stop the workspace in https://gitpod.io/workspaces, open it again, and confirm that setting is the same:
Check that
~/.ddev
points to${XDG_CONFIG_HOME}/ddev
Automated Testing Overview
Release/Deployment Notes