Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grabbing bug #485

Closed
BannZay opened this issue May 16, 2016 · 5 comments
Closed

Grabbing bug #485

BannZay opened this issue May 16, 2016 · 5 comments
Labels
bug An unintended feature or error in the code. editor Related to the map editor.

Comments

@BannZay
Copy link
Contributor

BannZay commented May 16, 2016

Grab something from picker(for example) switch chosed layer then brush. This way you could do a lot of bugs.
For example grab tune tile - swithc to tele - draw = not working but marked tele tiles
Grabbing game freeze - switch to tele - paint = game crash.

@timakro
Copy link
Member

timakro commented May 17, 2016

Can't replicate, for me no unused index is placeable in the tele layer.

@BannZay
Copy link
Contributor Author

BannZay commented May 17, 2016

Try to use exactly paint feature (pick entitie -> press shift and paint some area)
P.s: here is a lot of ways how to crash client this way

@timakro
Copy link
Member

timakro commented May 17, 2016

Ah right, I would call that filling, thanks for the report.

@timakro
Copy link
Member

timakro commented May 17, 2016

In my opinion the logic for checking if a tile is allowed to be placed should be shifted to the new GetTile method I introduced for game and front layer already. It doesn't support extra data though like for example the number of the tune zone for tune layer.

[4:41:08 PM] Tim: yeah id like to push stuff like BrushDraw only to CLayerTiles
[4:41:15 PM] Tim: because its basically the same for all layers
[4:41:22 PM] Tim: just that some tiles are removed is different
[4:41:31 PM] Tim: and that logic can go to SetTile
[4:41:37 PM] Tim: but I'm too lazy to do that
[4:41:48 PM] Tim: also we would need a more general type that represents tiles
[4:42:17 PM] Tim: maybe we could inherit from CTile
[4:42:20 PM] Tim: to CTileTele
[4:42:34 PM] Tim: which additionally stores the tele number
[4:42:56 PM] Tim: SetTile and GetTile work with CTile
[4:43:07 PM] Tim: and CLayerTele::SetTile could cast the CTile it takes to CTileTele

[4:52:14 PM] Tim: yes the correct thing to do is to make CTileLayers::BrushDraw call CLayerTele::GetTile which returns a CTileTele casted to a CTile and then call CLayerTele::SetTile a lot of times for every tile we want to fill

@timakro timakro added the bug An unintended feature or error in the code. label May 17, 2016
@def- def- closed this as completed in df6e3a5 Jan 11, 2019
def- added a commit that referenced this issue Jan 11, 2019
Made it impossible to copy layer content to another layer and then use
autofiller on that: https://forum.ddnet.tw/viewtopic.php?f=16&t=6450

This reverts commit df6e3a5.
@def- def- reopened this Jan 11, 2019
@def- def- added the editor Related to the map editor. label Mar 1, 2019
ChillerDragon pushed a commit to chillerbot/chillerbot-ux that referenced this issue Apr 27, 2019
ChillerDragon pushed a commit to chillerbot/chillerbot-ux that referenced this issue Apr 27, 2019
Made it impossible to copy layer content to another layer and then use
autofiller on that: https://forum.ddnet.tw/viewtopic.php?f=16&t=6450

This reverts commit df6e3a5.
@C0D3D3V
Copy link
Contributor

C0D3D3V commented Jun 17, 2022

I can not reproduce this in latest master. Maybe it is fixed.
If I try to do the steps, then only the tiles of the other layers are removed at the marked location, but nothing else happens.

@def- def- closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unintended feature or error in the code. editor Related to the map editor.
Projects
None yet
Development

No branches or pull requests

4 participants