Switch verified icon to checkmark again (by MiM) #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
added a commit
to def-/ddnet
that referenced
this pull request
Mar 24, 2019
- As requested by qshar and KoG players - Similar to DDNet tab - Info fetched from servers-kog entry from https://info.ddnet.tw/info - Also supports countries and types - Doesn't inform whether map has been finished - Generalized the code a bit but it's still ugly - Depends on ddnet#1533, also shows KoG servers as official/verified
|
LGTM I guess bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 25, 2019
1533: Switch verified icon to checkmark again (by MiM) r=heinrich5991 a=def- As proposed in https://forum.ddnet.tw/viewtopic.php?t=6783&p=67593#p67593 Looks more discreet and more teeish to me and not like some overloaded DDNet advertisement.   Co-authored-by: Dennis Felsing <dennis@felsin9.de>
|
The vote went against the change btw :D |
ChillerDragon
pushed a commit
to chillerbot/chillerbot-ux
that referenced
this pull request
Apr 27, 2019
- As requested by qshar and KoG players - Similar to DDNet tab - Info fetched from servers-kog entry from https://info.ddnet.tw/info - Also supports countries and types - Doesn't inform whether map has been finished - Generalized the code a bit but it's still ugly - Depends on ddnet#1533, also shows KoG servers as official/verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in https://forum.ddnet.tw/viewtopic.php?t=6783&p=67593#p67593
Looks more discreet and more teeish to me and not like some overloaded DDNet advertisement.