fixed faulty message id #2040
Merged
fixed faulty message id #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, are you sure we can do this? Looks a bit like a protocol change. I'll
take a better look later
…On Sun, Jan 19, 2020, 21:13 Chiller Dragon ***@***.***> wrote:
@ChillerDragon <https://github.com/ChillerDragon> requested your review
on: #2040 <#2040> fixed faulty message
id.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2040?email_source=notifications&email_token=AADXYBEJTQ3S5QIJODT7KV3Q6SX4ZA5CNFSM4KI3JJU2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWB7SRNI#event-2961123509>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADXYBFTMGV7JBSFPYU6GV3Q6SX4ZANCNFSM4KI3JJUQ>
.
|
|
@Learath2 tbh I have no clue. But I tested it and the client can still connect to ddnet and non ddnet servers and works fine as far as I know. Also tested with dummy. But yes please take a look. Im scared. I am especially unsure about this part because I improvised there: |
|
Ok here is everything I tested (all worked fine) Client:
Server:
|
(cherry picked from commit teeworlds/teeworlds@9023796)
ChillerDragon
force-pushed
the
pr_fix_message
branch
from
0d8622c
to
1b4131a
Compare
|
@heinrich5991 if you have a couple minutes can you take a look at this? I'm not completely familiar with the entire thing |
|
Looks good to me. Thanks. bors r+ |
heinrich5991
approved these changes
Jan 24, 2020
bors bot
added a commit
that referenced
this pull request
Jan 24, 2020
2040: fixed faulty message id r=heinrich5991 a=ChillerDragon (cherry picked from commit teeworlds/teeworlds@9023796) Co-authored-by: oy <Tom_Adams@web.de>
Build failed
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jan 24, 2020
2040: fixed faulty message id r=heinrich5991 a=ChillerDragon (cherry picked from commit teeworlds/teeworlds@9023796) Co-authored-by: oy <Tom_Adams@web.de>
Build failed
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jan 24, 2020
2040: fixed faulty message id r=heinrich5991 a=ChillerDragon (cherry picked from commit teeworlds/teeworlds@9023796) Co-authored-by: oy <Tom_Adams@web.de>
Build failed
|
|
New day, lets hope Microsoft fixed their repository. bors retry |
bors bot
added a commit
that referenced
this pull request
Jan 25, 2020
2040: fixed faulty message id r=heinrich5991 a=ChillerDragon (cherry picked from commit teeworlds/teeworlds@9023796) Co-authored-by: oy <Tom_Adams@web.de>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit teeworlds/teeworlds@9023796)