New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability, see official teeworlds news #359

Merged
merged 1 commit into from Nov 21, 2015

Conversation

Projects
None yet
4 participants
@heinrich5991

This comment has been minimized.

Contributor

heinrich5991 commented Nov 2, 2015

This is not a proper fix, it's just a hack.

@Schwertspize

This comment has been minimized.

Contributor

Schwertspize commented Nov 2, 2015

ehm nice Heinrich. on tw forum you say we should apply it, here you say we should not.

@heinrich5991

This comment has been minimized.

Contributor

heinrich5991 commented Nov 2, 2015

We should commit a proper fix to the repository, not just the hack.

@Tardo

This comment has been minimized.

Contributor

Tardo commented Nov 2, 2015

commit in vanilla no? i see that DDRaceNetwork are too distanced of vanilla master no?

@heinrich5991

This comment has been minimized.

Contributor

heinrich5991 commented Nov 2, 2015

Oh nvm, I thought this was the official teeworlds repository. You're free to apply this to ddnet obviously (sorry!).

H-M-H added a commit that referenced this pull request Nov 21, 2015

Merge pull request #359 from Schwertspize/patch-1
Fix vulnerability, see official teeworlds news

@H-M-H H-M-H merged commit 019fb0e into ddnet:master Nov 21, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@H-M-H H-M-H referenced this pull request Nov 21, 2015

Closed

remove hack #377

@Schwertspize Schwertspize deleted the Schwertspize:patch-1 branch Nov 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment