Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android build scripts #4085

Merged
merged 1 commit into from Aug 24, 2021
Merged

Conversation

Jupeyy
Copy link
Member

@Jupeyy Jupeyy commented Aug 15, 2021

This is mostly finished, adds the scripts and the minimal code changes needed.
It does NOT add any functionalty.

What is missing:

  • Can't get opusfile to compile for 32bit (arm and x86), probably because I set the paths wrong (I just build it manually for now and define the 64bit ftello fseeko to the c standard ones)
  • libcurl probably requires openssl for https, or I forgot to enable it, LAN servers should work tho (certificate is downloaded at build time, bcs the android certs cannot be used with newer OpenSSL versions apparently)
  • I didn't shell check the scripts, would be really pleased if someone wants todo it (Thanks to @ChillerDragon)
    - [ ] README doesn't mention it (could also be done after the pr is merged) (dont want todo it)
  • Choose landscape mode by default (can be done in the java code)
  • App icons are missing
  • fix Rare(?) random(?) crash on Android #4086

fixes #4086

fixes #477

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test if it works standalone, system.c especially
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

@Jupeyy Jupeyy force-pushed the pr_android_build_script branch 12 times, most recently from ee900a5 to 09b38e5 Compare August 18, 2021 23:23
@Jupeyy
Copy link
Member Author

Jupeyy commented Aug 18, 2021

I think this is done if somebody wants to try it out

scripts/android/README.md

should explain most stuff, the easiest is to just download android studio and download NDK and SDK tools
and just run the script for your arch for testing
you can then just plugin your phone over USB and install with

adb install build_android/DDNet.apk

@Jupeyy Jupeyy force-pushed the pr_android_build_script branch 3 times, most recently from bb98f53 to afd72eb Compare August 22, 2021 14:36
@Jupeyy Jupeyy marked this pull request as ready for review August 22, 2021 14:38
@def-
Copy link
Member

def- commented Aug 24, 2021

Looks great, unfortunately I don't have an Android device anymore to try it out. I'd merge it to prevent conflicts in this change in the future, it should only really affect the Android build anyway. Could you resolve the conflicts?

@def-
Copy link
Member

def- commented Aug 24, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 24, 2021

@bors bors bot merged commit 7e69796 into ddnet:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rare(?) random(?) crash on Android Android support for SDL2
2 participants